fix(pi): ack messages after sendUserMessage succeeds#66
Open
philosophicalsmith-beep wants to merge 1 commit into
Open
fix(pi): ack messages after sendUserMessage succeeds#66philosophicalsmith-beep wants to merge 1 commit into
philosophicalsmith-beep wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sendUserMessagesucceedspendingAckIdfrom staying set when Pi does not emit the deferred extension input ackProblem
Pi delivery currently sets
pendingAckIdbefore callingsendUserMessage, then waits for the deferred input ack path to clear it. In practice, messages delivered throughsendUserMessage(..., { deliverAs: "followUp" })may not trigger that ack path reliably. OncependingAckIdremains set, later wake events skip delivery and unread hcom messages stay queued.Observed locally before this change:
notify_server.wakewith the oldpending_ackFix
After
sendUserMessagereturns successfully, callackPending(...)right away. At that point the message has been handed to Pi's input queue, so hcom can safely mark it delivered instead of waiting on an extension input callback that may not arrive.If
sendUserMessagethrows, the existing catch path still clearspendingAckIdand reports the delivery error.Verification
cargo checkcargo build --releaseKAVA_ONE,KAVA_TWO, andKAVA_THREEhcom pi-read --name kavareturned[]plugin.deferred_ackwithsource: "sendUserMessage:followUp", followed by later wake events withpending_ack: null