fix(codex): remove unsupported --full-auto and transition to modern flags#34
Closed
khoant94 wants to merge 1 commit into
Closed
fix(codex): remove unsupported --full-auto and transition to modern flags#34khoant94 wants to merge 1 commit into
khoant94 wants to merge 1 commit into
Conversation
…lags Problem: hcom hardcodes the --full-auto flag when launching Codex agents. Modern codex-cli (v0.128.0+) rejects this flag, causing launch failures with an 'unexpected argument' error. Solution: - Replaced --full-auto with modern flags (--sandbox workspace-write --ask-for-approval on-request) in src/tools/codex_preprocessing.rs. - Removed --full-auto from the Codex argument parser in src/tools/codex_args.rs. - Updated src/config.rs to normalize legacy 'full-auto' sandbox mode to 'workspace' instead of 'danger-full-access'. - Updated unit tests in codex_preprocessing, codex_args, config, and terminal.
Contributor
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
hcom hardcodes the
--full-autoflag when launching Codex agents. Moderncodex-cli(v0.128.0+) rejects this flag, causing launch failures with an 'unexpected argument' error.Solution
--full-autowith modern flags (--sandbox workspace-write --ask-for-approval on-request) insrc/tools/codex_preprocessing.rs.--full-autofrom the Codex argument parser insrc/tools/codex_args.rs.src/config.rsto normalize legacy 'full-auto' sandbox mode to 'workspace' instead of 'danger-full-access'.codex_preprocessing,codex_args,config, andterminal.Test Plan
cargo test codex_argscargo test codex_preprocessingcargo test config--full-autois now rejected by the parser and correctly replaced in preprocessing logic.