-
Notifications
You must be signed in to change notification settings - Fork 4.6k
Add unified thinking effort control across all providers #9242
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jh-block
wants to merge
35
commits into
main
Choose a base branch
from
jhugo/unified-thinking-effort
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 27 commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
facbb55
Add unified thinking effort control across all providers
jh-block 0692f5a
Remove legacy thinking/reasoning env vars and model-name-suffix effort
jh-block 13b846a
Migrate legacy model name effort suffixes at ModelConfig construction
jh-block a0f49c0
Address PR review comments: fix legacy suffix stripping, merge reques…
jh-block c460f49
Filter thinking_effort from Databricks payload; honor Off for Gemini …
jh-block f9f1312
Avoid overriding suffix-derived thinking effort with default 'off' in…
jh-block c8b15b2
Persist displayed default effort on submit; restrict Claude thinking …
jh-block 3e022e0
Normalize effort suffix on deserialized configs; restrict CLI Claude …
jh-block abae039
Rename request param merge helper and remove Option arg
jh-block 8ace93f
Normalize legacy effort suffix during ModelConfig deserialization
jh-block 4de6aed
Migrate Codex provider to unified thinking effort
jh-block a3ae644
Add unified thinking effort support for chatgpt_codex
jh-block 8c7c1f0
chore: revert cli-providers.md doc change to match origin/main
jh-block c24ba82
Address DOsinga's review: drop local ThinkingEffort enum, simplify te…
jh-block e7706d6
Fix unified thinking effort edge cases
jh-block 58fa143
Update desktop i18n messages
jh-block 305dd77
Fix ACP model request params merge
jh-block 4ec5585
Address thinking effort review feedback
jh-block dbe809a
Clamp OpenAI reasoning efforts by model
jh-block 4b6561a
Preserve Responses API thinking effort
jh-block a8084ca
Address model config review feedback
jh-block 8d5da61
Address thinking effort review feedback
jh-block de07979
Preserve explicit none thinking effort
jh-block db5e545
Gate Responses reasoning config by model
jh-block 09ce5ce
Address thinking effort review feedback
jh-block 00fddd2
Support OpenRouter thinking effort
jh-block c0b4bce
Use Databricks endpoint metadata for thinking
jh-block 53de26d
Address reasoning effort review feedback
jh-block ab17833
Address Databricks review feedback
jh-block ef49673
Clear stale model reasoning metadata
jh-block 6aae898
Preserve Gemini 3 thinking level fallback
jh-block b494213
Preserve thinking effort fallbacks
jh-block c8f0cac
Scope legacy thinking budget fallbacks
jh-block 6c3901c
Move reasoning detection to core
jh-block cc2ad22
Apply OpenRouter reasoning fallback
jh-block File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new CLI gating excludes Claude models unless the provider is
anthropicordatabricks, sogoose configureskips the unifiedGOOSE_THINKING_EFFORTprompt for OpenRouter Claude selections even though this commit adds OpenRouter reasoning support viaapply_reasoning_configwhen a model is reasoning-capable. In practice, configuringopenrouterwith a reasoning Claude model (for exampleclaude-sonnet-4*) leaves users unable to set thinking effort through the CLI path, making the new feature unavailable from the primary setup flow.Useful? React with 👍 / 👎.