fix: replace Venice custom provider with declarative config#9234
Merged
Conversation
The Venice provider had a buggy hand-rolled message formatter that only converted the first tool response per message to a proper 'role: tool' message. When the assistant made multiple tool calls in one turn, the remaining tool results were silently dropped, causing the upstream API to reject with 'tool_use ids were found without tool_result blocks'. Venice is a standard OpenAI-compatible API. Replace the 566-line custom provider with a declarative JSON config that delegates to the OpenAI provider, which correctly handles multi-tool responses, streaming, images, thinking, and all other features. Fixes #7444 Signed-off-by: Douwe Osinga <douwe@squareup.com>
jh-block
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the 566-line custom Venice provider with a ~25-line declarative JSON config.
Problem
The Venice provider had a buggy hand-rolled message formatter that only converted the first tool response per message into a proper
role: toolmessage. When the assistant made multiple tool calls in one turn, the remaining tool results were silently dropped, causing the upstream API to reject the request with:Solution
Venice is a standard OpenAI-compatible API (
/api/v1/chat/completions). Instead of patching the buggy formatter, this PR deletes the entire custom provider and replaces it with a declarative JSON config that delegates to the existingOpenAiProvider. This:role: toolmessage per tool responsetemperature: 0.7andmax_tokens: 2048What's dropped (cosmetic only)
llama-3.3-70b [cvfsw])VENICE_BASE_PATHandVENICE_MODELS_PATH(nobody uses these)Changes
+crates/goose/src/providers/declarative/venice.json— new declarative config-crates/goose/src/providers/venice.rs— deleted (566 lines)~crates/goose/src/providers/mod.rs— removedpub mod venice~crates/goose/src/providers/init.rs— removedVeniceProviderregistrationFixes #7444