fix: widen MOIM allowlist to suppress expected fix_conversation warnings#9226
Merged
Conversation
Add 'Removed trailing assistant message' and 'Merged text content' to the allowlist in inject_moim. Both are expected side effects of inserting a user message before the last assistant message and are automatically corrected by fix_conversation. Fixes #8274 Signed-off-by: Douwe Osinga <douwe@squareup.com>
tlongwell-block
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
Removed trailing assistant messageandMerged text contentto the allowlist ininject_moim. Both are expected side effects of inserting a user message before the last assistant message and are automatically corrected byfix_conversation.This eliminates the 142+ WARN-level log messages per session reported in the issue.
Fixes #8274