Skip to content

fix: goose configure exits silently at the model picker #8790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ahmadelafify wants to merge 1 commit into from
Closed

fix: goose configure exits silently at the model picker #8790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions crates/goose-cli/src/commands/configure.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -740,6 +740,11 @@ pub async fn configure_provider_dialog() -> anyhow::Result<bool> {
.await
};
spin.stop(style("Model fetch complete").green());
// cliclack's spinner render thread outlives `stop()` and races the next
// prompt's raw-mode stdin read; drop and yield so the picker's
// `interact()` doesn't fail before any key is read. See #8373.
drop(spin);
tokio::time::sleep(std::time::Duration::from_millis(50)).await;

// Select a model: on fetch error show styled error and abort; if models available, show list; otherwise free-text input
let model: String = match models_res {
Expand Down
Loading