test(jolt-openings): regression tests for failing Fiat--Shamir transform#1536
Open
mmaker wants to merge 2 commits into
Open
test(jolt-openings): regression tests for failing Fiat--Shamir transform#1536mmaker wants to merge 2 commits into
mmaker wants to merge 2 commits into
Conversation
…nsform. In jolt-openings today, the opening points and the polynomial commitments are not absorbed before rho is sampled in the "reduction" phase. As a result, the challenge can be predicted on some batching protocols. This commit adds regression tests that highlight the issue.
mmaker
force-pushed
the
mu/regression-fs-batching
branch
from
b6578a6 to
237b3c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In jolt-openings today, the opening points and the polynomial commitments are not part of the Fiat--Shamir transformation.
As a result, the challenge can be predicted on some batching protocols.
This commit adds regression tests highlighting this issue.
/cc @shreyas-londhe