Fix issue 2539 ffmpeg pixel_format option for libx264 in FFMPEG_VideoWriter class#2544
Open
kevinmagnopus wants to merge 3 commits intoZulko:masterfrom
Open
Fix issue 2539 ffmpeg pixel_format option for libx264 in FFMPEG_VideoWriter class#2544kevinmagnopus wants to merge 3 commits intoZulko:masterfrom
kevinmagnopus wants to merge 3 commits intoZulko:masterfrom
Conversation
…der in FFMPEG_VideoWriter
…_ffmpeg_writer.py
… class describing the new pixel format behavior for libx264
Author
|
@Zulko may I request that you please review this PR. This PR addresses a bug where it is not possible to generate a lossless h264 video. We have a use case for lossless h264, but we currently unable to achieve it due to the bug addressed in this PR. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
tests/