Skip to content

Fix bugs that may occur in the file_to_subtitles function #2492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hupanbdfx wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bugs that may occur in the file_to_subtitles function #2492

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions moviepy/video/tools/subtitles.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -195,4 +195,7 @@ def file_to_subtitles(filename, encoding=None):
current_times, current_text = None, ""
elif current_times:
current_text += line
# Fix the issue where the subtitle is not added to times_texts when it is the last line in an SRT file and the loop ends.
if current_times is not None:
times_texts.append((current_times, current_text.strip("\n")))
return times_texts
Loading