Fixed_ArchLinux_preview_not_working#2483
Open
ZippyBagi wants to merge 2 commits intoZulko:masterfrom
Open
Conversation
On Arch linux ffplay_versions always return an error since on arch ffmpeg versions start with an "n" and then the version number. I have fixed this, now it works
keikoro
requested changes
Sep 15, 2025
| result = subprocess.run(cmd, capture_output=True, text=True, check=True) | ||
| # Extract the version number from the first line of output | ||
| full_version = result.stdout.splitlines()[0].split()[2] | ||
| #On Arch linux ffmpeg versions start with n, then the version number, this makes sure that no errors occur. |
Collaborator
There was a problem hiding this comment.
I can't comment on the code side of this, but would ask you clean up the comment. Spelling of proper names and punctuation should be fixed (missing whitespace after # for consistency with other comments; use full stop or semi-colon to split the sentence in two for readability).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Arch linux moviepy.video.io.ffmpeg_tools.tools.ffplay_versions() always returned an error - this made it so that the preview function of clips wasn't working. On arch ffmpeg versions start with an "n" and then the version number. I have fixed this, now it works. This bug only occured on arch linux as far as I can tell.