fix(ledger): re-checkout cargo config in clippy/rust_tests jobs too#106
Merged
Conversation
The clippy and rust_tests jobs cache ./app/rust/.cargo (which includes the tracked config.toml) too. A pre-migration cache restores an old config.toml with build-std over the checkout; once the host toolchain is nightly that build-std rebuilds host core -> E0152 duplicate lang item. Apply the same re-checkout of the committed config.toml after the cache restore in these two jobs (build_ledger/build_package already do this).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to the build_ledger/build_package cache-clobber fix. The
clippyandrust_testsjobs also cache./app/rust/.cargo(incl. the trackedconfig.toml); a pre-migration cache restores an oldconfig.tomlwithbuild-stdover the checkout. Once an app moves its host toolchain to nightly (immediate-abort via Cargo.toml profile), that stalebuild-stdrebuilds hostcore→E0152: duplicate lang item.Adds the same post-restore
git checkout -- app/rust/.cargo/config.tomlto both jobs.v3tag moved to this commit. Surfaced by Zondax/ledger-icp#332.