fix(ledger): re-checkout app/rust/.cargo/config.toml after Rust cache restore#105
Merged
Merged
Conversation
… restore
The Rust dependency cache stores ${cargo_home} = app/rust/.cargo, which
includes the tracked config.toml. actions/cache restores it *after*
checkout, so a cache from before the nightly migration overwrites the
checked-out config.toml with a pre-migration copy that still sets
build-std-features = ["panic_immediate_abort"]. nightly-2025-12-05
rejects that (it is now the immediate-abort panic strategy, not a
build-std feature), so build_ledger/build_package fail to compile core.
Re-checkout the committed config.toml from HEAD right after each Rust
cache restore so the in-repo config always wins. Survives existing
poisoned caches without needing them deleted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Rust dependency cache in
_ledger_main.ymlstores${cargo_home}=app/rust/.cargo, which includes the trackedconfig.toml.actions/cacherestores it after
actions/checkout, so a cache produced before thenightly migration overwrites the checked-out
config.tomlwith apre-migration copy that still sets
build-std-features = ["panic_immediate_abort"].nightly-2025-12-05rejects that (it is now theimmediate-abortpanicstrategy, not a build-std feature), so
build_ledger/build_package_*fail with
could not compile core.This bit every app adopting the nightly/immediate-abort migration
(app-icp #54, app-avalanche #61, app-oasis #34): the change builds fine
locally and in
zondax/ledger-app-builder:latestwith a clean cargo, butCI restored the poisoned cache over it.
Fix: after each Rust cache restore, re-checkout the committed
config.tomlfromHEADso the in-repo config always wins. Works evenwith the existing poisoned caches (no cache deletion needed) and is a
no-op for apps without a tracked
app/rust/.cargo/config.toml.Note: the moving
v3tag was already force-moved to this commit tounblock the in-flight PRs; this PR lands the same fix on
mainso it isnot lost if
v3is recut.