feat(_release-rust): opt-in bare Windows .exe release asset#102
Merged
Conversation
Adds opt-in input upload_windows_exe (default false → backward-compatible). When set, Windows targets also publish the Authenticode-signed binary as a first-class asset <binary_name>-<triple>.exe (+ .sha256) alongside the .zip, so winget can install it as InstallerType: portable (no zip-nesting; avoids the nested-portable upgrade/uninstall hang). Same gating pattern as build_deb.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opt-in
upload_windows_exe(default false → backward-compatible, sov10can keep floating). When enabled, Windows targets publish the Authenticode-signed binary as a first-class release asset<binary_name>-<triple>.exe(+.sha256) in addition to the.zip(cargo-binstall still uses the zip).Why: deep research on winget packaging found that a bare
.exeasInstallerType: portableis more robust than zip→nested-portable — komac doesn't auto-detect nested-portable fields, and nested-portable has an upgrade/uninstall hang risk (winget-cli #3279/#4242). kache'spackage-publish.ymlwinget job consumes this.exe.Backward-compatible: gated
if: inputs.upload_windows_exe && contains(matrix.target, 'windows'), default off — same pattern asbuild_deb. Merge → movev10to include it; kache #374 already setsupload_windows_exe: true(so kache #374 must merge after this).