Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/review.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,12 @@ jobs:
ASTER_MODEL: ${{ vars.ASTER_MODEL }}
ASTER_HYPOTHESIS_MODEL: ${{ vars.ASTER_HYPOTHESIS_MODEL }}
ASTER_VERIFY_MODEL: ${{ vars.ASTER_VERIFY_MODEL }}
# DeepSeek's thinking models spend the reply budget on reasoning
# before they answer. At the 8000-token default a 40 KB diff chunk
# ran out with no answer, so give each reply more room and each
# chunk less diff.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hard-coded 32000 output tokens can exceed model output limits — high/error-handling · 75% confident

If the AI model chosen for the review isn't allowed to return that much text at once, every review request is refused and the bot never posts its comments.

Fix: Make the token budget per-model (e.g. ASTER_MAX_TOKENS / ASTER_VERIFY_MAX_TOKENS / ASTER_HYPOTHESIS_MAX_TOKENS) and cap it to the model's known output limit, or have the code clamp to the provider limit rather than hard-coding a global value.

ASTER_MAX_TOKENS: "32000"
ASTER_HYPOTHESIS_CHUNK_BYTES: "20000"
GITHUB_TOKEN: ${{ steps.app-token.outputs.token }}
run: |
aster review \
Expand Down
Loading