Conversation
fifield
requested review from
andrej,
jackl-xilinx and
pvasireddy-amd
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the device-detection regex used by the lit helper library to correctly recognize Strix Halo (multi-word) NPU names in XRT output.
Changes:
- Adjusted the
detect_xrtregex to allow spaces inNPU <name>matches. - Tightened trailing-match handling by consuming whitespace before the column delimiter.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fifield
force-pushed
the
halo_lit_regex
branch
from
6440e38 to
45801f9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix regular expression for detecting Strix Halo npu in lit helper library.
copied from #2288