Enable dynamic objectfifo lowering by default#2549
Merged
Conversation
Collaborator
|
Andra, just to let you know I have one of Endri's GEMM designs with the dynamic object FIFO and did not measure any performance degradation vs. the unrolled ObjectFIFO. |
The original change defaulted --dynamic-objFifos to true in cl_arguments.py (Python aiecc), but that file was deleted when aiecc.py was deprecated in favour of the C++ aiecc. Apply the equivalent change to tools/aiecc/aiecc.cpp. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
abisca
force-pushed
the
default-dynamicObjFifos
branch
from
7fb9331 to
b953c1f
Compare
Contributor
Coverage ReportCreated: 2026-05-06 17:19Click here for information about interpreting this report.
Generated by llvm-cov -- llvm version 18.1.3 |
abisca
requested review from
abisca,
andrej,
denolf,
fifield,
hunhoffe,
jackl-xilinx,
jgmelber,
pvasireddy-amd and
stephenneuendorffer
as code owners
hunhoffe
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses some points from #2441