Repository navigation
chore: move to .NET 11 (building from source now needs the .NET 11 SDK) - #594
Merged
Merged
Conversation
Targets net11.0 and builds with SDK 11.0.x in CI. The Docker image moves to the 11.0-resolute images: .NET 11 has no noble tag. Package updates: Microsoft.Extensions.* 11.0.0, Microsoft.CodeAnalysis.CSharp 5.9.0, BouncyCastle 2.7.0, GitVersion.MsBuild 6.8.2, Sep 0.17.1, Serilog 4.4.0 with its console sink and logging bridge, Google.Protobuf 3.36.2, and the test packages. Grpc.Tools goes from the 2.84 prerelease to 2.85.0, which still bundles protoc 35.1 and the universal macOS binary. Microsoft.Extensions.Logging.Abstractions and DependencyInjection.Abstractions are part of the base framework on net11.0, so Framework no longer references them (NU1510). Two packages stay behind on purpose: - Verify.XunitV3 at 32.0.1. From 33.0.0 the build fails (SC021) until a sponsorship or an exemption is declared. - xunit.v3 at 3.2.2. Version 4 brings Microsoft.Testing.Platform 2, which refuses `dotnet test` in VSTest mode. Verify 32 fails a snapshot that contains a carriage return, which is what core.autocrlf=true checks out on Windows, so *.verified.txt is now eol=lf. The snapshots themselves are unchanged. Built, tested and published on Windows x64, macOS arm64 and Linux arm64. The Windows build was played with the 1.14, 2.5.3, 3.4.3 and 4.4.2 clients. Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the solution to .NET 11 and brings the dependencies up to date.
Release archives are self-contained, so nothing changes for people who download them. Building from source now needs the .NET 11 SDK.
What changes
net11.0as the target framework, SDK11.0.xin the three workflows (the 10.0.x + 11 preview pair is gone).sdk:11.0-resoluteandruntime-deps:11.0-resolute-chiseled. .NET 11 publishes nonobleimages.Microsoft.Extensions.Logging.AbstractionsandMicrosoft.Extensions.DependencyInjection.Abstractionsare part of the base framework on net11.0.Frameworkno longer references them (NU1510 otherwise).*.verified.txtiseol=lfin.gitattributes. Verify 32 fails a snapshot that contains a carriage return, which is whatcore.autocrlf=truechecks out on Windows. The snapshots themselves are unchanged.Held back on purpose
dotnet testin VSTest mode. Moving means aglobal.jsonopt-in and new filter arguments in CI, the docs and the scripts, which is a change of its own.Test coverage
Build, unit tests and publish on three platforms
Each run is the whole solution on SDK 11.0.100:
dotnet build, the full xUnit suite (4785 tests), then the Release publish CI does. macOS and Linux ran from a fresh clone of master with this change on top.Live clients, Windows Release build
Four real clients, each logged in through the proxy to a real server and driven by a script that asks the client itself what it sees. Every session ended with no unhandled opcode and no error beyond the socket closing at logout.
What the checks cover:
One thing to know: on the first 4.4.2 run 296 of 297 checks passed. The server refused one Heroic Leap cast. The same check then passed on its own and in a second full run.
Not covered
🤖 Generated with Claude Code