Skip to content

chore: move to .NET 11 (building from source now needs the .NET 11 SDK) - #594

Merged
Xian55 merged 1 commit into
masterfrom
chore/dotnet-11
Nov 10, 2026
Merged

Xian55 merged 1 commit into
masterfrom
chore/dotnet-11

Conversation

@Xian55

@Xian55 Xian55 commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Moves the solution to .NET 11 and brings the dependencies up to date.

Release archives are self-contained, so nothing changes for people who download them. Building from source now needs the .NET 11 SDK.

What changes

  • net11.0 as the target framework, SDK 11.0.x in the three workflows (the 10.0.x + 11 preview pair is gone).
  • Docker: sdk:11.0-resolute and runtime-deps:11.0-resolute-chiseled. .NET 11 publishes no noble images.
  • Packages:
Package From To
Microsoft.Extensions.Hosting, Options.DataAnnotations 10.0.2 11.0.0
Microsoft.CodeAnalysis.CSharp 4.14.0 5.9.0
BouncyCastle.Cryptography 2.4.0 2.7.0
GitVersion.MsBuild 6.5.1 6.8.2
Sep 0.12.2 0.17.1
Grpc.Tools 2.84.0-pre1 2.85.0
Google.Protobuf 3.36.1 3.36.2
Serilog, Sinks.Console, Extensions.Logging 4.3.0, 6.0.0, 9.0.2 4.4.0, 6.1.1, 10.0.0
Microsoft.NET.Test.Sdk 18.0.1 18.11.1
coverlet.collector 6.0.4 10.1.0
Moq 4.20.72 4.21.0
Microsoft.Extensions.TimeProvider.Testing 10.10.0 10.11.0
Verify.XunitV3 29.0.0 32.0.1
  • Grpc.Tools 2.85.0 is a stable release that still bundles protoc 35.1 and the universal macOS binary, so the prerelease pin is no longer needed.
  • Microsoft.Extensions.Logging.Abstractions and Microsoft.Extensions.DependencyInjection.Abstractions are part of the base framework on net11.0. Framework no longer references them (NU1510 otherwise).
  • *.verified.txt is eol=lf in .gitattributes. Verify 32 fails a snapshot that contains a carriage return, which is what core.autocrlf=true checks out on Windows. The snapshots themselves are unchanged.

Held back on purpose

  • Verify.XunitV3 stays at 32.0.1. From 33.0.0 the build fails with SC021 until a sponsorship or an exemption is declared in MSBuild.
  • xunit.v3 stays at 3.2.2 (and its Visual Studio runner at 3.1.5). Version 4 brings Microsoft.Testing.Platform 2, which refuses dotnet test in VSTest mode. Moving means a global.json opt-in and new filter arguments in CI, the docs and the scripts, which is a change of its own.

Test coverage

Build, unit tests and publish on three platforms

Each run is the whole solution on SDK 11.0.100: dotnet build, the full xUnit suite (4785 tests), then the Release publish CI does. macOS and Linux ran from a fresh clone of master with this change on top.

Build Tests (passed / skipped / failed) Publish
Windows x64 0 warnings 4751 / 34 / 0 win-x64
macOS arm64 (Apple M4) 0 warnings 4742 / 43 / 0 osx-arm64
Linux arm64 (Debian 12) 0 warnings 4748 / 37 / 0 linux-arm64
  • The extra skips on macOS and Linux are tests gated to another platform (native AES-GCM with the 12-byte tag, a Windows stop signal, an open-file case).
  • The movement block tests ran once per build pair, six pairs, byte for byte against their snapshots: no pair failed.
  • The suite forces the BouncyCastle AES-GCM path and checks it against the platform cipher in both directions, so BouncyCastle 2.7.0 is covered for the world socket's encryption.
  • The source generator snapshots are unchanged, with Roslyn 5.9.0 as the generators' reference.
  • The trim warnings of the Release publish (IL2026, IL2065) are the ones master already prints.

Live clients, Windows Release build

Four real clients, each logged in through the proxy to a real server and driven by a script that asks the client itself what it sees. Every session ended with no unhandled opcode and no error beyond the socket closing at logout.

Client Server Checks Result
1.14.0 cMaNGOS classic 38 pass
2.5.3 cMaNGOS TBC 38 pass
3.4.3 AzerothCore (playerbots) 55 pass
4.4.2 TrinityCore 4.3.4 303 pass

What the checks cover:

  • All four: login and world entry, the player's own data (money, bags, spell book, talents, skills, reputations, quest log), chat and an emote, an aura going on and off, a spell learned and unlearned, other players in view, a movement packet.
  • 3.4.3 as well: the currency list the proxy builds from honor and arena points.
  • 4.4.2 as well: explored zones, calendar, the message of the day, raid frame profiles, currency, titles, the PvP window, a guild with its weekly challenges, forced reactions, the dungeon finder's lists, a chat channel of one's own, hover (own and another unit's), class power slots, archaeology, gathering and loot, glyphs, talent specialization, attack power and haste fields, spell modifiers, collision height, a roll, cleared cooldowns, item enchantments, and a Heroic Leap's parabolic spline.

One thing to know: on the first 4.4.2 run 296 of 297 checks passed. The server refused one Heroic Leap cast. The same check then passed on its own and in a second full run.

Not covered

  • Linux x64: CI builds and tests it on this PR.
  • The Docker image on the new base images.
  • The published macOS and Linux binaries were built, not played: every client session ran on the Windows build.
  • Two-client play (party, trade, duel), dungeons and long sessions.
  • Performance: no benchmark was run on .NET 11.

🤖 Generated with Claude Code

Targets net11.0 and builds with SDK 11.0.x in CI. The Docker image moves to
the 11.0-resolute images: .NET 11 has no noble tag.

Package updates: Microsoft.Extensions.* 11.0.0, Microsoft.CodeAnalysis.CSharp
5.9.0, BouncyCastle 2.7.0, GitVersion.MsBuild 6.8.2, Sep 0.17.1, Serilog
4.4.0 with its console sink and logging bridge, Google.Protobuf 3.36.2, and
the test packages. Grpc.Tools goes from the 2.84 prerelease to 2.85.0, which
still bundles protoc 35.1 and the universal macOS binary.

Microsoft.Extensions.Logging.Abstractions and DependencyInjection.Abstractions
are part of the base framework on net11.0, so Framework no longer references
them (NU1510).

Two packages stay behind on purpose:
- Verify.XunitV3 at 32.0.1. From 33.0.0 the build fails (SC021) until a
  sponsorship or an exemption is declared.
- xunit.v3 at 3.2.2. Version 4 brings Microsoft.Testing.Platform 2, which
  refuses `dotnet test` in VSTest mode.

Verify 32 fails a snapshot that contains a carriage return, which is what
core.autocrlf=true checks out on Windows, so *.verified.txt is now eol=lf.
The snapshots themselves are unchanged.

Built, tested and published on Windows x64, macOS arm64 and Linux arm64.
The Windows build was played with the 1.14, 2.5.3, 3.4.3 and 4.4.2 clients.

Co-Authored-By: Claude <noreply@anthropic.com>
@Xian55 Xian55 added the ai Artificial Intelligence contribution label Nov 10, 2026
@Xian55 Xian55 changed the title chore: move to .NET 11 and update the dependencies chore: move to .NET 11 (building from source now needs the .NET 11 SDK) Nov 10, 2026
@Xian55
Xian55 merged commit 48c3536 into master Nov 10, 2026
6 checks passed
@Xian55
Xian55 deleted the chore/dotnet-11 branch November 10, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai Artificial Intelligence contribution

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant