Repository navigation
fix: accept CMaNGOS 0x6000 elevator and tram guids - #592
Conversation
CMaNGOS classic numbers elevators and trams (gameobject type 11) with the guid high 0x6000 since mangos-classic 85e06ac9d (2026-11-06), one commit after the ship change of #590. Before it they went out as plain gameobjects, 0xF110. The proxy did not know 0x6000: each one became a null guid, logged "Unknown legacy high-guid 0x6000", and the create then threw NullReferenceException in StoreObjectUpdateInternal. The update packet it came in was lost whole, so the shaft stayed empty and everything else in that packet was missing too. 0x6000 now maps to a transport, beside 0xF120. On the way back the guid is rebuilt with the high the server sent, which LegacyTransportGuidHigh keeps the way LegacyMoTransportGuidHigh does for ships. It follows the last high seen, so one proxy serves a server from either side of the commit with no setting. The default stays 0xF120 for every other core, and an older CMaNGOS classic keeps its elevators as gameobjects. Verified with a 1.14.2 client on the Undercity lift, on a CMaNGOS classic built from each side of the commit: the character rides from the shaft floor to the top and back, and the server reports it aboard the lift. The moves sent from the platform carry 0x6000 on the one server and 0xF110 on the other. Without the fix the 0x6000 server shows no lift and the character never leaves the floor. With the lift created but its guid still sent back as 0xF120, the client rides and the server never takes the character aboard. A boat ride on the 0x6000 server still passes. Refs #590 Co-Authored-By: Claude <noreply@anthropic.com>
ProofA 1.14.2 client on the Undercity lift (gameobject 20649), against two builds of CMaNGOS classic: one that numbers elevators The character stands on the shaft floor and takes a small step every second or so for about 50 seconds, three rounds of the lift. Every 1.5 s the server is asked where it has the character (
What the rows say:
Also on the Not run: the Deeprun Tram, and VMaNGOS, 2.5 and 3.4.3 clients. The |
Summary
0x6000since mangos-classic 85e06ac9d (2026-11-06), one commit after the ship change of fix: accept CMaNGOS 0x8000 MO_TRANSPORT guids #590. Before it they went out as plain gameobjects,0xF110.0x6000. It loggedUnknown legacy high-guid 0x6000for each of them and then threwNullReferenceExceptioninStoreObjectUpdateInternal. The update packet the elevator came in was lost whole: the shaft stayed empty, and everything else in that packet was missing too.0x6000now maps to a transport, beside0xF120.LegacyTransportGuidHighkeeps it, the wayLegacyMoTransportGuidHighdoes for ships. It follows the last high seen, so one proxy serves a server from either side of that commit, with no setting. The default stays0xF120for every other core, and an older CMaNGOS classic keeps its elevators as gameobjects.Test plan
dotnet test -c Release: all passed. New tests cover the mapping, the round trip in both highs, a change of high under a running proxy, an elevator and a ship from the same server, an elevator sent as a plain gameobject, and the create that threw, through the real handler. That last test fails with the exception above when the mapping is taken out.0x6000, the Undercity lift: the character rides from the shaft floor to the top and back, and the server reports it aboard the lift. The moves sent from the platform carry0x6000.Unknown legacy high-guid 0x6000ten times, oneNullReferenceExceptionon a 3.5 kB update packet, no lift, and the character never leaves the shaft floor.0xF120to that server: the client rides, the server never takes the character aboard. So both directions are needed.0xF110): the same ride passes, before and after this change, and the moves carry0xF110.0x6000server (ships are0x8000there): still passes.0xF120, which is still the default.The local
0x6000server is an older CMaNGOS classic with the two guid commits applied, not a full upstream build.The progress pages were regenerated and did not change.
Refs #590
🤖 Generated with Claude Code