Repository navigation
fix: accept CMaNGOS 0x8000 ship and zeppelin guids - #591
Merged
Merged
Conversation
CMaNGOS classic numbers ships and zeppelins with the guid high 0x8000 since mangos-classic d9d50349b (2026-11-06). The proxy knew only 0x1FC0: each one became a null guid, logged "Unknown legacy high-guid 0x8000", and the create then threw NullReferenceException in StoreObjectUpdateInternal. Every update packet with a ship in it was lost whole, so no transport reached the client, and on a server that sends them in the login batch the player's own create went with them. 0x8000 now maps to an MO transport, beside 0x1FC0. On the way back the guid is rebuilt with the high the server sent, which LegacyMoTransportGuidHigh keeps as the item and corpse highs are kept. It follows the last high seen rather than latching, so servers from before and after the commit both work, and so does one swapped for the other under a running proxy. The default stays 0x1FC0 for every other core. Verified with a 1.14.2 client on a CMaNGOS classic built with each high: boarding at Menethil Harbor, sailing, the map change in mid-sea and docking at Theramore still on the ship. The moves sent from the deck carry 0x8000 on the one server and 0x1FC0 on the other. Without the fix the 0x8000 server shows no ship at all. With the ship created but its guid still sent back as 0x1FC0, that server never takes the passenger aboard: the ship sails and the character dies in the sea. The stuck login was not reproduced: the local server sends its transports in a packet of their own. The progress pages are regenerated. Fixes #590 Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
0x8000since mangos-classic d9d50349b (2026-11-06). The proxy knew only0x1FC0, loggedUnknown legacy high-guid 0x8000for each of them and then threwNullReferenceExceptioninStoreObjectUpdateInternal. Every update packet with a ship in it was lost whole.0x8000now maps to an MO transport, beside0x1FC0.LegacyMoTransportGuidHighkeeps it, as the item and corpse highs are kept. It follows the last high seen, so servers built before and after that commit both work with the same proxy, with no setting. The default stays0x1FC0for every other core.Test plan
dotnet test -c Release: all passed. New tests cover the mapping, the round trip in both highs, a change of high under a running proxy, and the create that threw, through the real handler. That last test fails with the reported exception when the mapping is taken out.0x8000: its ships and zeppelins reach the client, none did before the fix. Boarding at Menethil Harbor, sailing, the map change in mid-sea and docking at Theramore, still on the ship. The moves sent from the deck carry0x8000.0x1FC0: the same ride passes and the moves carry0x1FC0.0x1FC0to the0x8000server: the server never takes the passenger aboard, the ship sails and the character dies in the sea. So both directions are needed.0x1FC0path, which is unchanged.Not covered: mangos-classic 85e06ac9d, one commit later, moves elevators and trams to the guid high
0x6000. The proxy does not know that one either.The progress pages are regenerated.
Fixes #590
🤖 Generated with Claude Code