Skip to content

fix: accept CMaNGOS 0x8000 ship and zeppelin guids - #591

Merged
Xian55 merged 1 commit into
masterfrom
fix/590-cmangos-motransport-guid
Nov 10, 2026
Merged

Xian55 merged 1 commit into
masterfrom
fix/590-cmangos-motransport-guid

Conversation

@Xian55

@Xian55 Xian55 commented Nov 10, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • CMaNGOS classic numbers ships and zeppelins with the guid high 0x8000 since mangos-classic d9d50349b (2026-11-06). The proxy knew only 0x1FC0, logged Unknown legacy high-guid 0x8000 for each of them and then threw NullReferenceException in StoreObjectUpdateInternal. Every update packet with a ship in it was lost whole.
  • 0x8000 now maps to an MO transport, beside 0x1FC0.
  • On the way back to the server the guid carries the high the server sent. LegacyMoTransportGuidHigh keeps it, as the item and corpse highs are kept. It follows the last high seen, so servers built before and after that commit both work with the same proxy, with no setting. The default stays 0x1FC0 for every other core.

Test plan

  • dotnet test -c Release: all passed. New tests cover the mapping, the round trip in both highs, a change of high under a running proxy, and the create that threw, through the real handler. That last test fails with the reported exception when the mapping is taken out.
  • The movement tests under all six build pairs: passed.
  • 1.14.2 on a CMaNGOS classic that uses 0x8000: its ships and zeppelins reach the client, none did before the fix. Boarding at Menethil Harbor, sailing, the map change in mid-sea and docking at Theramore, still on the ship. The moves sent from the deck carry 0x8000.
  • 1.14.2 on a CMaNGOS classic that uses 0x1FC0: the same ride passes and the moves carry 0x1FC0.
  • Control, ship created but its guid sent back as 0x1FC0 to the 0x8000 server: the server never takes the passenger aboard, the ship sails and the character dies in the sea. So both directions are needed.
  • The stuck login itself was not reproduced. The local server is an older CMaNGOS with only the guid high changed, and it sends its transports in a packet of their own, so the player's create survived there.
  • VMaNGOS, 2.5 and 3.4.3 clients: not run. They take the 0x1FC0 path, which is unchanged.

Not covered: mangos-classic 85e06ac9d, one commit later, moves elevators and trams to the guid high 0x6000. The proxy does not know that one either.

The progress pages are regenerated.

Fixes #590

🤖 Generated with Claude Code

CMaNGOS classic numbers ships and zeppelins with the guid high 0x8000
since mangos-classic d9d50349b (2026-11-06). The proxy knew only 0x1FC0:
each one became a null guid, logged "Unknown legacy high-guid 0x8000",
and the create then threw NullReferenceException in
StoreObjectUpdateInternal. Every update packet with a ship in it was
lost whole, so no transport reached the client, and on a server that
sends them in the login batch the player's own create went with them.

0x8000 now maps to an MO transport, beside 0x1FC0. On the way back the
guid is rebuilt with the high the server sent, which
LegacyMoTransportGuidHigh keeps as the item and corpse highs are kept.
It follows the last high seen rather than latching, so servers from
before and after the commit both work, and so does one swapped for the
other under a running proxy. The default stays 0x1FC0 for every other
core.

Verified with a 1.14.2 client on a CMaNGOS classic built with each
high: boarding at Menethil Harbor, sailing, the map change in mid-sea
and docking at Theramore still on the ship. The moves sent from the
deck carry 0x8000 on the one server and 0x1FC0 on the other. Without
the fix the 0x8000 server shows no ship at all. With the ship created
but its guid still sent back as 0x1FC0, that server never takes the
passenger aboard: the ship sails and the character dies in the sea.
The stuck login was not reproduced: the local server sends its
transports in a packet of their own.

The progress pages are regenerated.

Fixes #590

Co-Authored-By: Claude <noreply@anthropic.com>
@Xian55 Xian55 added bugfix A fix has been proposed or merged for this reported bug ai Artificial Intelligence contribution cmangos cmangos server labels Nov 10, 2026
@Xian55
Xian55 merged commit fa16ae5 into master Nov 10, 2026
5 checks passed
@Xian55
Xian55 deleted the fix/590-cmangos-motransport-guid branch November 10, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai Artificial Intelligence contribution bugfix A fix has been proposed or merged for this reported bug cmangos cmangos server

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: accept CMaNGOS 0x8000 MO_TRANSPORT guids

1 participant