Skip to content

fix: show an inspected player's talents on a 2.4.3 server - #589

Merged
Xian55 merged 1 commit into
masterfrom
fix/588-tbc-inspect-talents
Nov 5, 2026
Merged

Xian55 merged 1 commit into
masterfrom
fix/588-tbc-inspect-talents

Conversation

@Xian55

@Xian55 Xian55 commented Nov 5, 2026

Copy link
Copy Markdown
Owner

Fixes #588.

What was wrong

On a 2.4.3 server, SMSG_INSPECT_TALENT carries a uint32 length (0x3D) and a talent bit array. Since #580 the proxy no longer misreads those bytes as 3.3.5a talent groups, but it did not read them at all, so a 2.5 client's inspect talent tree stayed empty: no points in any tab, every rank 0.

The fix

cMaNGOS TBC (HandleInspectOpcode) sets one bit per learned talent, for the rank the player has. A class's three tabs follow one another, and inside a tab the talents go by row, column and id, each taking as many positions as it has ranks. It packs seven positions to a byte and leaves the high bit clear.

The 2.5.2 (40892) and 2.5.3 (42328) clients' Talent and TalentTab tables match the 2.4.3 Talent.dbc and TalentTab.dbc the server loads: all 579 talents have the same tab, row, column and max rank, and every tab has the same class and order. So every talent sits at the same position on both sides, for every class, and the proxy only changes the packing to eight positions per byte (InspectTalentBits). It needs no talent tables and allocates nothing per inspect beyond the packet's own list. The client gets 25 bytes, which covers 200 positions; the class with the most, warrior, uses 199.

@celguar's decoder (celguar/HermesProxy@e3f3973) was the starting point for this. Thank you!

Verified

  • Two 2.5.3 clients on cMaNGOS TBC. A 46/6/0 rogue was inspected by a second player: master showed tab1=0, tab2=0, tab3=0. With the fix, the inspect shows all 19 talents with the same ranks and tab points as the rogue's own talent frame.
  • The modern capture carries the expected 25 bytes in SMSG_INSPECT_RESULT (845 bytes against 820 on master).
  • The inspected gear (random property, random suffix, gem, permanent enchantment) still matches the wearer's own view.
  • dotnet test: 4736 passed, 0 failed. InspectTalentBitsTests maps every position from 0 to 199 and the rogue's captured array. TBCInspectGearTests.ATalentedPlayer_KeepsTheirTalents (2.4.3-pinned run) fails with the fix taken out.

Also regenerates docs/wotlk-progress.md and docs/cata-progress.md.

🤖 Generated with Claude Code

A 2.4.3 server answers an inspect with a talent bit array, which the
proxy has left unread since #580, so the 2.5 client's inspect talent
tree stayed empty: no points in any tab, every rank 0.

cMaNGOS TBC packs seven positions to a byte and leaves the high bit
clear. The 2.5.2 and 2.5.3 clients read the array eight positions to a
byte, and their Talent and TalentTab tables give every talent the
position 2.4.3's give it (all 579 talents, every class). So the bits
are repacked as they are, and the proxy needs no talent tables.

Verified with two 2.5.3 clients on cMaNGOS TBC: a 46/6/0 rogue's 19
talents show in the inspect with the ranks of its own talent frame, and
the inspected gear is unchanged.

Fixes #588

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Xian55 Xian55 added bugfix A fix has been proposed or merged for this reported bug ai Artificial Intelligence contribution cmangos cmangos server tbc The Burning Crusade Expansion labels Nov 5, 2026
@Xian55
Xian55 merged commit a3d313d into master Nov 5, 2026
5 checks passed
@Xian55
Xian55 deleted the fix/588-tbc-inspect-talents branch November 5, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai Artificial Intelligence contribution bugfix A fix has been proposed or merged for this reported bug cmangos cmangos server tbc The Burning Crusade Expansion

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TBC 2.4.3: an inspected player's talent tree is empty on 2.5.3 clients

1 participant