Skip to content

fix: tell a release build about a newer release - #585

Merged
Xian55 merged 2 commits into
masterfrom
fix/583-update-check
Nov 2, 2026
Merged

Xian55 merged 2 commits into
masterfrom
fix/583-update-check

Conversation

@Xian55

@Xian55 Xian55 commented Nov 1, 2026

Copy link
Copy Markdown
Owner

Fixes #583

The update check could not announce anything. It asked WowLegacyCore/HermesProxy, whose last release is from 2023, and it returned for any build with commits since the last tag. Release binaries are built before their tag exists, so that was all of them: v4.7.0 reports 4.7.0+10(95ed7b0).

Changes

  • The check asks this repository and links to it.
  • It skips builds that aren't from master. Shipped binaries carry Branch.master, checked in v4.7.0 and v4.6.113.
  • It compares the tag as a version instead of by date.
  • The notice is a log warning. It used to be console text followed by a 10 s Thread.Sleep. Nobody met that while the check was dead, but releases land several times a day, so a working check would have stalled nearly every start.
  • The check runs after Log.Configure, so the warning can reach the log file.

Behaviour change: a release build now calls the GitHub API at each start. On a machine that can't reach it, that waits up to 5 s, the client's timeout. --no-version-check turns it off, and the Docker image already has it off.

Also here

ConfigReference.ToMarkdown now normalises line endings. Its raw strings take the source file's, so on a Windows checkout with core.autocrlf ConfigReferenceTests.Page_MatchesTheSettings failed on every run, even right after regenerating the page. That came with #582. CI runs its tests on Linux and macOS and didn't see it.

Tested

Real Release binaries against the live GitHub API, built from a clone without the v4.7.0 tag so they are older than the latest release:

Build Result
Code before this PR, on master No notice
This PR, on master HermesProxy v4.7.0 is out and this is 4.6.114. Get it from https://github.com/Xian55/HermesProxy/releases/latest, started in 2 s
This PR, on another branch No notice
  • UpdateCheckTests covers the version comparison.
  • Local dotnet test: 4722 passed, 34 skipped, on a CRLF checkout. 54 of 55 full runs passed. The other failed DynamicSetUpdateField_ComputedIndex_AllocatesNothing, in code this PR doesn't touch: Allocation test failed once in a full run #584.
  • The warning was seen on the console, not read back from the log file.

🤖 Generated with Claude Code

Xian55 and others added 2 commits November 2, 2026 00:32
ConfigReference.ToMarkdown uses raw strings, which take the line endings of the source file. On a
Windows checkout with core.autocrlf those are CRLF, so ConfigReferenceTests failed there even right
after regenerating the page. CI runs its tests on Linux and macOS and never saw it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The update check could not announce anything. It asked WowLegacyCore/HermesProxy, whose last release
is from 2023, and it returned for any build with commits since the last tag. Release binaries are
built before their tag exists, so that was all of them: v4.7.0 reports 4.7.0+10(95ed7b0).

It now asks this repository, and skips builds that aren't from master, which is what shipped binaries
are. The tag is compared as a version instead of by date.

The notice is a log warning now. It used to be console text followed by a 10 s sleep, which nobody
met while the check was dead, but releases land several times a day, so a working check would have
stalled nearly every start. The check moved after Log.Configure so the warning reaches the log file.

Fixes #583

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@Xian55 Xian55 added bugfix A fix has been proposed or merged for this reported bug ai Artificial Intelligence contribution labels Nov 1, 2026
@Xian55
Xian55 merged commit d0d2371 into master Nov 2, 2026
5 checks passed
@Xian55
Xian55 deleted the fix/583-update-check branch November 2, 2026 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ai Artificial Intelligence contribution bugfix A fix has been proposed or merged for this reported bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update check can't announce a release

1 participant