Skip to content

fix: Allocate TaggedCache::getKeys() memory outside of lock #7567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ximinez wants to merge 3 commits into
base: develop
Choose a base branch
from
+10 −2
Open

fix: Allocate TaggedCache::getKeys() memory outside of lock #7567

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9b3dd70
fix: Allocate TaggedCache::getKeys() memory outside of lock
ximinez Jun 17, 2026
eb4681d
Merge branch 'develop' into ximinez/fix-getkeys
ximinez Jun 17, 2026
0542847
Apply suggestion from @xrplf-ai-reviewer[bot]
ximinez Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions include/xrpl/basics/TaggedCache.ipp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

#include <xrpl/basics/IntrusivePointer.ipp>
#include <xrpl/basics/TaggedCache.h>
#include <xrpl/basics/scope.h>

namespace xrpl {

Expand Down Expand Up @@ -536,8 +537,15 @@ TaggedCache<Key, T, IsKeyCache, SharedWeakUnionPointer, SharedPointerType, Hash,
std::vector<key_type> v;

{
std::scoped_lock const lock(mutex_);
v.reserve(cache_.size());
std::unique_lock lock(mutex_);
for (int size = cache_.size(); v.capacity() < size; size = cache_.size())
Comment thread
ximinez marked this conversation as resolved.
Outdated
{
ScopeUnlock const unlock(lock);
v.reserve(size);
}
XRPL_ASSERT(lock.owns_lock(), "xrpl::TaggedCache::getKeys(): owns lock");
XRPL_ASSERT(
v.capacity() >= cache_.size(), "xrpl::TaggedCache::getKeys(): sufficient capacity");
for (auto const& _ : cache_)
v.push_back(_.first);
}
Expand Down
Loading