Skip to content

fix: Allocate TaggedCache::getKeys() memory outside of lock#7567

Open
ximinez wants to merge 3 commits into
developfrom
ximinez/fix-getkeys
Open

fix: Allocate TaggedCache::getKeys() memory outside of lock#7567
ximinez wants to merge 3 commits into
developfrom
ximinez/fix-getkeys

Apply suggestion from @xrplf-ai-reviewer[bot]

0542847
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 17, 2026 in 0s

82.0% (target 75.0%)

View this Pull Request on Codecov

82.0% (target 75.0%)

Details

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.0%. Comparing base (480676d) to head (0542847).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #7567   +/-   ##
=======================================
  Coverage     82.0%   82.0%           
=======================================
  Files         1007    1007           
  Lines        76876   76880    +4     
  Branches      8981    8981           
=======================================
+ Hits         63001   63005    +4     
  Misses       13866   13866           
  Partials         9       9           
Files with missing lines Coverage Δ
include/xrpl/basics/TaggedCache.ipp 86.5% <100.0%> (+0.2%) ⬆️

... and 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.