Skip to content

feat: Mark Sponsor as Supported::Yes#7556

Open
mvadari wants to merge 1 commit into
xrplf/sponsorfrom
xrplf/sponsor-supported
Open

feat: Mark Sponsor as Supported::Yes#7556
mvadari wants to merge 1 commit into
xrplf/sponsorfrom
xrplf/sponsor-supported

Conversation

@mvadari

@mvadari mvadari commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

High Level Overview of Change

Title says it all

Context of Change

For easier testing

API Impact

N/A

Copilot AI review requested due to automatic review settings June 16, 2026 18:18

@xrplf-ai-reviewer xrplf-ai-reviewer Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues.

Review by Claude Sonnet 4.6 · Prompt: V15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR changes the amendment registry to mark the Sponsor amendment as Supported::Yes, which affects how rippled reports and handles amendment support (and therefore network compatibility / amendment-blocking behavior).

Changes:

  • Mark Sponsor as Supported::Yes in the registered amendments list.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

// Keep it sorted in reverse chronological order.

XRPL_FEATURE(Sponsor, Supported::No, VoteBehavior::DefaultNo)
XRPL_FEATURE(Sponsor, Supported::Yes, VoteBehavior::DefaultNo)
// Keep it sorted in reverse chronological order.

XRPL_FEATURE(Sponsor, Supported::No, VoteBehavior::DefaultNo)
XRPL_FEATURE(Sponsor, Supported::Yes, VoteBehavior::DefaultNo)
@codecov

codecov Bot commented Jun 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.3%. Comparing base (4fc781e) to head (97a9ff4).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           xrplf/sponsor   #7556     +/-   ##
===============================================
- Coverage           82.3%   82.3%   -0.0%     
===============================================
  Files               1018    1018             
  Lines              78268   78268             
  Branches            8972    8972             
===============================================
- Hits               64390   64384      -6     
- Misses             13869   13875      +6     
  Partials               9       9             

see 2 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants