-
Notifications
You must be signed in to change notification settings - Fork 1.7k
feat: XLS-68: Sponsor, #5887 continuation #7350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
oleks-rip
wants to merge
302
commits into
develop
Choose a base branch
from
xrplf/sponsor
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 250 commits
Commits
Show all changes
302 commits
Select commit
Hold shift + click to select a range
dbbfc13
test for Vault
tequdev b096662
add InvariantChecks for pseudo-account
tequdev 75aaeb5
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 1ee2508
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 5b64ff0
address 5594, 5592 changes
tequdev bc1ef1e
add tests for XChainBridge
tequdev 59c3d5b
add insufficient reserve check for xchain, vault
tequdev 4126d53
Merge remote-tracking branch 'origin/develop' into sponsor
tequdev ee385e9
fix bad merge
tequdev 101b70f
add assert when adding/removing sponsor field to LedgerEntry
tequdev bc71d9c
Add support for extra transaction signature validation
ximinez d597726
refactor: signature autofilling for Simulate RPC
tequdev 8d32b0f
Add jtx, STObject, and RPC support for sig object fields
ximinez 1441abc
use `sfSponsorSignature`
tequdev 9df0ad6
Merge branch 'sponsor-new-signing' into sponsor
tequdev 28c5cad
fix transactions.macro format
tequdev a6b0eff
typo
tequdev 32cc782
Merge branch 'refactor-simulate-autofill' into sponsor
tequdev 754f597
Support sfSponsorSignature autofilling in Simulate RPC
tequdev 7f922c4
reserve co-signing
tequdev a65cf6e
add tests for sponsor flags
tequdev d8dc000
add prefunded sponsor tests
tequdev 5d597e3
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 2337d34
Allow delegation for Sponsorship transactions
tequdev 4fe7e87
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev d0bcca6
Fix the behavior of co-sign + pre-fund
tequdev 965ecd3
Add sponsored outer batch
tequdev 774917d
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev b4188a8
address reviews
tequdev 3e6d6c6
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 13145f6
fix header name
tequdev 297083e
fix: specify type for adjust variable in SetOracle transaction proces…
tequdev cd62f7f
remove copyright
tequdev e03c7a9
add sponsor transfer test
tequdev fbf403a
add tests for sponsor field
tequdev a49cb91
add tests
tequdev 3f96735
fix comment for LCOV
tequdev af9d91b
add tests fro SponsorshipTransfer
tequdev 9d1b5eb
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev b5db596
update Sponsored VaultCreate test
tequdev c38cb90
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 7f0a940
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev a9629ae
address reviews
tequdev d96998c
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev e49d338
address SponsorshipSet reviews
tequdev f5e2195
address reviews
tequdev ea29fe5
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 0f36de8
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 198f3f8
remove unused insSponsorCoSigning args
tequdev 163a2ac
add `sfPreviousTxnID` and `sfPreviousTxnLgrSeq` to ltSponsorship
tequdev 2813fea
address review
tequdev cf03c4c
change Sponsor related fields to `soeDEFAULT`
tequdev edddf3f
address review
tequdev dc325a9
Merge branch 'develop' into sponsor
tequdev 0791ca1
fix template exception
tequdev 82b146b
fix ripple -> xrpl
tequdev 1e8f6ce
address reviews
tequdev ffb5382
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev f88e964
allow `sponsee` on cspell
tequdev ec05613
fix typo
tequdev 1bc5a1b
address spec changes (payment flags/ iou amount)
tequdev f885f02
address spec changes (sfReserveCount, sfFeeAmount)
tequdev 5b91d81
address revew (std::optional + std::shared_ptr<SLE>)
tequdev 9e65dba
fix redundant co-signed sponsor check
tequdev c321e10
address reviews
tequdev 3568df4
add `calculateReserve` helper
tequdev c3e5bcf
address review (DeleteAccount)
tequdev 52ae31b
Merge commit 'c9458b72cab68d3cbbf533cc87d14309c2eb93b7' into sponsor
tequdev 204138f
Revert the use of calculateReserve in xrpLiquid
tequdev f333dd1
add signature existence check, consume ReserveCount if pre-funded spo…
tequdev 1823d70
refactor Oracle Reserve calculation
tequdev 990627f
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev ce8049a
fix parseSponsorship
tequdev 88e870b
change sfSponsor to STAccount, Sponsor flags as global flags
tequdev 87718bd
remove unused HashPrefix
tequdev 8be44c7
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev ab1de45
add comment
tequdev 5f385e0
update to use sfSponsorFlags
tequdev 6576823
Payback ReserveCount
tequdev d7ab1b4
Separate test suite
tequdev c0de722
`sfHigh/LowSponsorAccount` -> `High/LowSponsor`
tequdev 5155a94
Add sponsor tests for Batch innerTxn
tequdev 4cd8d0d
fix simulate test
tequdev 175a2df
chang `sfFeeAmount` to `soeOPTIONAL`
tequdev 7cdaa24
Fixed the minimum amount for creating a Sponsored Account.
tequdev 40cf599
Add sanity check for sponsoringAccountCount = 0
tequdev 8f8fc03
Add InvariantChecks for if OwnerCount < SponsoredOwnerCount
tequdev 0a41002
refactor SponsorshipSet flag checks
tequdev 4a205eb
add checks to accountReserve and fix sponsored owner count for xrpLiquid
tequdev 527d7bb
fix to return error if FeeAmount > Balance on SponsorshipSet
tequdev 8d24afe
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 4e87de7
add test for Sponsored trustline
tequdev d390bc7
clang-format
tequdev f820908
Add tests for LoanBroker transactions
tequdev 37f4ea9
Add tests for Loan
tequdev 49c5269
`sfSponsorAccount` -> `sfSponsor`/`sfCounterpartySponsor`
tequdev fe07547
address review
tequdev e1aee43
address review
tequdev 446681d
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 392a913
audit 3
tequdev d1d613d
audit 4
tequdev c1e1be5
audit 5
tequdev 686f945
audit 6
tequdev bf4fa37
audit 7
tequdev f6d79f7
audit 8
tequdev 9859ba8
audit 9
tequdev 9cde57d
audit 10
tequdev fe5fab0
audit 11
tequdev 2fd8e1b
audit 12
tequdev dcfcb1f
audit 13
tequdev 293394f
audit 14
tequdev 178bb8f
Allow zero value for ReserveCount, FeeAmount, MaxFee
tequdev f86b255
Add `SponsorshipEnd/Create/Reassign` flags for SponsorshipTransfer
tequdev 4a91351
Add `sfSponsee` to `ttSponsorshipTransfer`
tequdev 1ad6dd1
Add tests for deleting Sponsor Account with ltSponsorship
tequdev 062ece3
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 9961887
clang-format
tequdev 53f407e
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev fb86735
use pragma once
tequdev d1eb22b
fix transactions.macro format
tequdev b9f1c97
format SetTrust.cpp
tequdev 8c8ecff
remove tx parameter from adjustOwnerCount()
tequdev 8a05e3d
remove unnecessary #endif in Sponsor.h and sponsor.h
tequdev 85e1f2b
Rename [sponsor|sponsee]Acc,[sponsor|sponsee]Account to [sponsor|spon…
tequdev 839ba17
Refactor: sponsorship-related helpers
tequdev c9666d7
refactor `adjustOwnerCount()` to use `adjustSponsorOwnerCountHlp()`
tequdev 15be714
remove unnecessary reserveCount check
tequdev c79814a
remove unused Sponsor.h
tequdev eb7e01d
Remove unused tx parameter from removeEmptyHolding()
tequdev 8d75f3b
remove `asfDisallowIncomingSponsor`
tequdev d95b6e4
Refactor variable declarations in xrpLiquid
tequdev 024ab07
minor fixes
tequdev 234d2e5
Refactor ownerCount and calculateReserve to use SLE::const_ref
tequdev 37c95ea
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 8baec56
pre-commit run --all-files
tequdev b32ff18
refactor getFeePayer()
tequdev f13945e
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 6555001
make sponsor helpers inline
tequdev e40e15a
fix C2, C4
tequdev f8a8c23
fix M2
tequdev 9a6432d
fix M3
tequdev d680386
fix M5
tequdev d1346fa
fix M6
tequdev 6d7ffcb
fix M7
tequdev b695b4b
Add comments for PreFunded sponsor reserve checks on TrustSet
tequdev 53bdfb2
Add comment to clarify that the door account should not have a sponso…
tequdev 2f0adfa
fix M11
tequdev 22bfc5e
fix M15
tequdev 968493f
fix M16
tequdev 64f699a
fix M17
tequdev 5280a18
fix L4
tequdev 7ddda1b
fix L5
tequdev 1adaeac
fix L14
tequdev de64bc7
fix L18
tequdev fd39368
fix L20
tequdev afcc3c6
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 98257d3
Fix SponsorshipSet targeting Pseudo Accounts to return an error
tequdev aacb8e4
return tem error when SponsorReserve flag is set in Batch OuterTxn
tequdev 41429dc
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev d0d4f1d
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 2505fa8
fix
tequdev 7c3ca98
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 3f4e88c
Merge remote-tracking branch 'xrplf/develop' into sponsor
tequdev 5a195d2
fix path
tequdev 3ea0067
clang-format
tequdev 07d0887
fix path
tequdev 700a528
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 4d29453
fix AccountObjects_test.cpp error
tequdev 831f998
clang-tidy
tequdev 7100369
Add test for no SponsorFlag with valid sponsor
tequdev a115d73
return `tecHAS_OBLIGATIONS` for any conditions when deleting account …
tequdev 4026af1
format
tequdev 25de0ce
fix comment
tequdev d524670
fix SponsorshipEnd Bypass
tequdev 828b475
fix Wrong Account Passed to getLedgerEntryOwner in doApply
tequdev 6bd2e91
fix Wrong Account in Sponsorship Keylet Lookup Causes Reserve Count
tequdev 9264136
fix deleteAMMTrustLine Reads Sponsor Fields After They Are Erased
tequdev 3df1e66
fix Unchecked std::optional Dereference in SponsorshipSet Create Path
tequdev 16e4f24
fix XRPL_ASSERT(false) to UNREACHABLE
tequdev 525adf1
fix reset() Does Not makeFieldAbsent for Zero FeeAmount
tequdev b6b3175
add test for insufficient balance to sponsor fee
tequdev 84e84fb
fix Sponsor able to provide sponsorship with just base reserve
tequdev 021eaa8
fix Co-Signed Sponsoring Bypasses Sponsor Balance Check
tequdev 31bc259
fix SponsorshipSet Update FeeAmount Lacks Reserve Floor Check
tequdev dd82977
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 52e7cdc
fix: Sponsored account creation double-counts base reserve #6894
tequdev 207a33d
fix: SponsorshipSet Update FeeAmount Lacks Reserve Floor Check
tequdev 7639bd9
fix: MPTokenIssuanceDestroy reads sponsor from erased SLE #6895
tequdev 773acf0
fix: SponsoringAccountCount has no overflow protection #6898
tequdev 278e25d
fix: Preclaim XRP reserve overestimate for sponsored checks #6899
tequdev bb27479
fix: TrustSet free trust line check uses sponsor's ownerCount, skippi…
tequdev b2b2bab
fix: PermissionedDomain invariant skips credential validation for Spo…
tequdev c072b12
fix: No invariant verifying sfSponsor field on objects matches sponso…
tequdev 3810944
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 6ee071c
fix: An incorrect available XRP balance check in AMM deposit allows r…
tequdev e8deaa1
pre-commit run
tequdev fbff1c0
levelization
tequdev c12eff6
apply tidy diff
tequdev b153213
run pre-commit
tequdev 84bffad
merge_fix
oleks-rip 9b4ab67
Fix delegable test
oleks-rip 462a0b2
Read/const_ref
oleks-rip ee8d9ca
More universal adjustSponsorOwnerCountHlp
oleks-rip c5941d6
Unify accountReserve, ownerCount, ownerReserve
oleks-rip 3ad93af
fix: Sponsor's MaxFee cap is bypassed in reset() path, allowing spons…
tequdev 688e568
fix: getLedgerEntryOwner missing ltLOAN_BROKER and ltLOAN prevents ob…
tequdev d057f07
fix: setSponsorFieldU32 silently clamps to 0 on underflow instead of …
tequdev aa70d60
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev 33be9ab
clang-format
tequdev 0c683bf
levelization
tequdev 86c90c8
clang-tidy
tequdev bca6d8e
fix not to payback ReserveCount
tequdev 50d5e2d
Merge remote-tracking branch 'upstream/develop' into sponsor
tequdev eb88c0e
Fix clang-format, some refactoring
oleks-rip 2b4ce0f
Merge fixes
oleks-rip d792e03
adjustOwnerCountObj, more checks, some fixes
oleks-rip 6f43655
Merge branch 'develop' into sponsor
tequdev c72fd59
clang-tidy
tequdev 77ebc29
clang-format
tequdev 405b314
fix clang-tidy error
tequdev b76652b
XRPL_ASSERT -> Throw
oleks-rip 9d4c496
fix tidy error
tequdev f042cd8
Merge remote-tracking branch 'ripple/develop' into dev_rename_merge
oleks-rip 960aaec
merge fixes
oleks-rip ab7bbac
Merge remote-tracking branch 'oleks-rip/dev_rename_merge' into sponsor
tequdev 7624c18
fix: XChainAddAccountCreateAttestation redirects relayer sponsorship …
tequdev a669099
fix
tequdev bb4c443
fix ReserveCount Inflation via Co-Signed + Pre-Funded Interaction
tequdev 08357b1
sponsor AccountID -> sponsorSle
oleks-rip 39e8199
Merge remote-tracking branch 'ripple/develop' into spns5
oleks-rip 0bfdfa7
Merge fixes
oleks-rip 9e5b728
Merge remote-tracking branch 'ripple/develop' into spns5
oleks-rip 0997b92
Merge fixes
oleks-rip 8d905ac
Merge remote-tracking branch 'ripp/develop' into spns5
oleks-rip 3859fca
clang-tidy fixes
oleks-rip d561f0d
Merge remote-tracking branch 'tequ/sponsor' into spns5
oleks-rip 595b612
Merge fixes
oleks-rip 9ef1949
Merge remote-tracking branch 'ripple/develop' into xrplf/sponsor
oleks-rip 03fb6d1
Codegen update
oleks-rip 7e5ac6f
Merge remote-tracking branch 'ripple/develop' into xrplf/sponsor
oleks-rip d70eca3
Merge remote-tracking branch 'ripple/develop' into xrplf/sponsor
oleks-rip 942a950
Codegen update
oleks-rip 64159eb
Revert clang-tidy
oleks-rip f650d52
Merge remote-tracking branch 'ripple/develop' into xrplf/sponsor
oleks-rip e521139
clang-tidy
oleks-rip 4fc781e
Merge remote-tracking branch 'ripp/develop' into xrplf/sponsor
oleks-rip 14986cc
Sponsorship should be non-obligated for sponsee (#7552)
yinyiqian1 aac6be2
fix new CI rule switch fallthrough (#7568)
yinyiqian1 c2ab83c
fix: Fix UBSan issue (#7554)
mvadari d1a77b4
Merge branch 'develop' of https://github.com/XRPLF/rippled into xrplf…
mvadari File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -266,6 +266,8 @@ words: | |
| - sles | ||
| - soci | ||
| - socidb | ||
| - sponsee | ||
| - sponsees | ||
| - SRPMS | ||
| - sslws | ||
| - statsd | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This helper only seems to be used in tests, so I think we should remove it