Skip to content

Refactor: checking Insufficient reserve to use helper function#5844

Open
tequdev wants to merge 13 commits into
XRPLF:developfrom
tequdev:refactor-insufficient-reserve-check
Open

Refactor: checking Insufficient reserve to use helper function#5844
tequdev wants to merge 13 commits into
XRPLF:developfrom
tequdev:refactor-insufficient-reserve-check

remove unused var

839e342
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 4, 2025 in 1s

78.9% (target 75.0%)

View this Pull Request on Codecov

78.9% (target 75.0%)

Details

Codecov Report

❌ Patch coverage is 96.82540% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.9%. Comparing base (5d79bfc) to head (839e342).

Files with missing lines Patch % Lines
src/xrpld/app/tx/detail/PayChan.cpp 85.7% 2 Missing ⚠️
src/xrpld/app/tx/detail/MPTokenIssuanceCreate.cpp 80.0% 1 Missing ⚠️
src/xrpld/app/tx/detail/XChainBridge.cpp 91.7% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##           develop   #5844     +/-   ##
=========================================
- Coverage     78.9%   78.9%   -0.0%     
=========================================
  Files          816     816             
  Lines        72075   72099     +24     
  Branches      8437    8420     -17     
=========================================
+ Hits         56865   56878     +13     
- Misses       15210   15221     +11     
Files with missing lines Coverage Δ
include/xrpl/ledger/View.h 100.0% <ø> (ø)
src/libxrpl/ledger/View.cpp 92.0% <100.0%> (+0.1%) ⬆️
src/xrpld/app/tx/detail/AMMWithdraw.cpp 95.4% <100.0%> (+<0.1%) ⬆️
src/xrpld/app/tx/detail/CreateCheck.cpp 97.4% <100.0%> (ø)
src/xrpld/app/tx/detail/CreateTicket.cpp 92.7% <100.0%> (ø)
src/xrpld/app/tx/detail/Credentials.cpp 96.6% <100.0%> (-<0.1%) ⬇️
src/xrpld/app/tx/detail/DID.cpp 94.7% <100.0%> (+0.1%) ⬆️
src/xrpld/app/tx/detail/DelegateSet.cpp 100.0% <100.0%> (ø)
src/xrpld/app/tx/detail/DepositPreauth.cpp 92.9% <100.0%> (-0.1%) ⬇️
src/xrpld/app/tx/detail/Escrow.cpp 94.4% <100.0%> (+<0.1%) ⬆️
... and 10 more

... and 6 files with indirect coverage changes

Impacted file tree graph

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.