update: Changes to the XLS-68 PR before merge#564
Open
mvadari wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates XLS-0068 (Sponsored Fees and Reserves) to align the specification with ongoing implementation work (notably rippled PR #7350), adding clarifications for pseudo-accounts, reserve carve-outs, Batch transaction behavior, and feature interactions.
Changes:
- Adds/clarifies sponsorship constraints around pseudo-accounts and pseudo-account–owned objects, plus reserve carve-out behavior.
- Specifies sponsorship rules and failure conditions related to Batch (XLS-56) and permissioned delegation interactions.
- Renumbers/extends later sections (Feature Interactions, Invariants, etc.) and updates various references (with some remaining inconsistencies).
| 1. The sponsor does not have enough XRP to cover the reserve (`tecINSUFFICIENT_RESERVE`). | ||
| 2. The transaction does not support reserve sponsorship (see section [8.3.4](#834-transactions-that-cannot-be-sponsored)) | ||
| 3. The transaction creates a ledger object whose owner is an account other than `tx.Account` (e.g. `AMMClawback` creating a trust line on behalf of the holder). | ||
| 4. The transaction includes an `sfDelegate` field and `spfReserve` is enabled. Reserve sponsorship combined with permissioned delegation is disallowed. |
Comment on lines
+782
to
+787
| 10. If transferring the sponsorship to a new sponsor: | ||
| 11. The transaction is not submitted by the sponsee (`tecNO_PERMISSION`) | ||
| 12. The `Sponsor` field or the `SponsorFlags` field is missing (`temMALFORMED`) | ||
| 13. The `SponsorFlags` field does not include the `spfSponsorReserve` flag (`temINVALID_FLAG`) | ||
| 14. The new sponsor account does not exist (`terNO_ACCOUNT`) | ||
| 15. The new sponsor does not have enough XRP to cover the reserve for this object/account (`tecINSUFFICIENT_RESERVE`) |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
High Level Overview of Change
Title says it all
Context of Change
XRPLF/rippled#7350
Type of Change