Proper support for RFC 6265 cookies - #97
Open
pavelhoral wants to merge 1 commit into
Open
Conversation
Add support for cookies with arbitrary attribute-value pairs. No special treatment for the obsolete RFC 2965. Additional attributes in Cookie header are silently ignored on parsing. This means that parsing old cookie header and then generating the same header again will produce different output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for cookies with arbitrary attribute-value pairs.
No special treatment for the obsolete RFC 2965. Additional cookie attributes in
Cookieheader are silently ignored on parsing. This means that parsing old cookie header and then generating the same header again will produce different output:The main motivation behind this change is to unlock the possibility to work with
SameSitecookie attribute. This attribute is only available when there is a possibility to add non-standard attribute to a cookie.The main inspiration for the
Cookierefactor was Jakarta EE 6Cookieclass.