Skip to content

Updated tanstack/react-virtual to 3.14.4 to add directDomUpdates #4022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dracofulmen wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Updated tanstack/react-virtual to 3.14.4 to add directDomUpdates #4022

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b0fcb45
Updated tanstack to v3.14.3 to add directDomUpdates
dracofulmen Jun 25, 2026
7738e3e
Updated package.json to use fix to scrolling
dracofulmen Jun 26, 2026
f45c15c
Added ref to MenuCard to anchor directDomUpdates
dracofulmen Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/react/collection/lib/useBaseListModel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -168,6 +168,7 @@ export const useBaseListModel = createModelHook({
estimateSize: React.useCallback(() => UNSTABLE_defaultItemHeight, [UNSTABLE_defaultItemHeight]),
horizontal: config.orientation === 'horizontal',
overscan: 3, // overscan of 3 helps rapid navigation
directDomUpdates: true,
});

// Force Typescript to recognize the `Generic` symbol
Expand Down
2 changes: 1 addition & 1 deletion modules/react/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@
"@emotion/react": "^11.7.1",
"@emotion/styled": "^11.6.0",
"@popperjs/core": "^2.5.4",
"@tanstack/react-virtual": "^3.13.9",
"@tanstack/react-virtual": "^3.14.3",

@coderabbitai coderabbitai Bot Jun 25, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🗄️ Data Integrity & Integration | 🟡 Minor

🧩 Analysis chain

🏁 Script executed:

#!/bin/bash
# Confirm the lockfile resolves 3.14.3 and check the registry host used.
rg -nP -C4 '`@tanstack/react-virtual`@' yarn.lock
# Surface any private-registry URLs that should not be committed.
rg -n '4873|10\.0\.0\.' yarn.lock .npmrc 2>/dev/null

Repository: Workday/canvas-kit

Length of output: 1474

Update yarn.lock for @tanstack/react-virtual

yarn.lock still resolves @tanstack/react-virtual@^3.13.9 to 3.13.9 from the public Yarn registry. The package bump in modules/react/package.json won’t take effect until the lockfile is refreshed to ^3.14.3; otherwise directDomUpdates won’t be available at runtime.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@modules/react/package.json` at line 53, The dependency bump in
modules/react/package.json for `@tanstack/react-virtual` is not reflected in the
lockfile, so update the yarn.lock entry for the `@tanstack/react-virtual` package
to resolve ^3.14.3 instead of the older ^3.13.9 version. Make sure the lockfile
entry matches the new version used by the React package so the runtime can
access directDomUpdates, and verify the existing dependency key for
`@tanstack/react-virtual` is refreshed consistently.

@dracofulmen dracofulmen Jun 25, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't actually update the yarn.lock on my side because it would contaminate it with changes from my personal setup

@coderabbitai coderabbitai Bot Jun 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dracofulmen, understood — thanks for clarifying.

That makes sense, and I wouldn’t want you to commit a polluted yarn.lock. The concern is still that this PR’s functional change depends on @tanstack/react-virtual actually resolving to 3.14.3; if the lockfile stays on 3.13.9, directDomUpdates may not be present at runtime.

Best path here is probably to have the lockfile refreshed from a clean/standard project environment by someone who can do that safely. If you want to keep that out of this PR, I can help open a follow-up issue for the lockfile update.

@dracofulmen dracofulmen Jun 25, 2026

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would hope that a reviewer would be able to generate the correct version of the new yarn.lock.

@coderabbitai coderabbitai Bot Jun 25, 2026

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dracofulmen Fair point — I agree this is better handled from a clean reviewer/maintainer environment than from a local setup that would dirty yarn.lock.

The concern I raised is still about making sure the lockfile actually resolves the new @tanstack/react-virtual version, but I won’t push this back on you if you can’t generate it safely from your machine.

"@workday/canvas-colors-web": "^2.0.0",
"@workday/canvas-expressive-icons-web": "1.0.2",
"@workday/canvas-kit-popup-stack": "^15.0.14",
Expand Down
Loading