Restrict featured image selection to single image#77213
Closed
adamsilverstein wants to merge 1 commit intotrunkfrom
Closed
Restrict featured image selection to single image#77213adamsilverstein wants to merge 1 commit intotrunkfrom
adamsilverstein wants to merge 1 commit intotrunkfrom
Conversation
The MediaUpload component for the featured image panel did not
explicitly set multiple={false}, allowing users to select multiple
images in the media library modal. Since a post can only have one
featured image, enforce single selection.
Props WordPress/wordpress-develop#8294.
See https://core.trac.wordpress.org/ticket/65053.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +2 B (0%) Total Size: 7.74 MB 📦 View Changed
ℹ️ View Unchanged
|
|
Flaky tests detected in f603d85. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/24220299664
|
Member
Author
|
I tested this manually and verified it fixes the issue reported in https://core.trac.wordpress.org/ticket/65053 |
Contributor
|
Unfortunately, the issue has not been resolved in my environment. Furthermore, it appears this problem is occurring elsewhere, such as with image blocks 🤔 e8a5098fe39fee4e64b81b409e3808d7.mp4 |
Member
Author
|
@t-hamano did you drag and drop those images onto the upload modal? I wonder if we get the same issue uploading to a gallery where multiples are allowed? |
Member
Author
I was unable to reproduce with the image block, any special steps @t-hamano ? please add more details or steps to reproduce. |
Contributor
Yes. As you were able to reproduce the issue here, you may need to clear your media library once.
The |
Member
Author
Hmm, I thought I had cleared the media library, but maybe not completely. I wonder if this has something to do with starting with an empty library somehow braking the math used to calculate the counts for display. I'll keep digging, this probably needs some fix in core. |
Member
Author
|
Closing in favor of the upstream fix in WordPress/wordpress-develop#11585. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
multiple={ false }to theMediaUploadcomponent in the featured image panelContext
The
MediaUploadcomponent for the "Set featured image" button did not explicitly disable multiple selection. While theonDropFileshandler already hadmultiple: false, the media library modal itself allowed multi-select, which is confusing since only the first selected image would be used.Trac ticket: https://core.trac.wordpress.org/ticket/65053
Test plan