Skip to content

Hotfix/WDSEN-56 Font Build Process + cleanup#85

Merged
thatmitchcanter merged 14 commits intomainfrom
hotfix/WDSEN-56-Font-Build-Process
Apr 21, 2026
Merged

Hotfix/WDSEN-56 Font Build Process + cleanup#85
thatmitchcanter merged 14 commits intomainfrom
hotfix/WDSEN-56-Font-Build-Process

Conversation

@khleomix
Copy link
Copy Markdown
Contributor

@khleomix khleomix commented Apr 1, 2026

Closes

https://app.clickup.com/t/9011385391/WDSEN-56

Link to test

Test locally

Description

  • Updates the font tooling to stop overwriting theme.json and instead merge font families safely. This keeps existing theme configuration intact while still syncing font assets and metadata from disk.
  • Style fixes to core Latest Comments, Latest Posts, and Lists (plus related core block SCSS touch-ups: Footnotes, Page List, Video, and a small editor bundle trim).
  • Block Showcase rendering and helpers refactored/expanded.
  • WebP handling tightened: correct Accept-based browser_supports_webp(), single footer inline script via wp_register_script / wp_add_inline_script with an explicit theme version (PHPCS), and block output respects browser WebP support where appropriate.
  • Dominant-color placeholders use dedicated registered style/script handles with explicit versions; docblocks and enqueue behavior updated.
  • Dependency / lockfile and minor build config updates.

Related Tickets & Documents

Mobile & Desktop Screenshots/Recordings

image

AI Assistance

  • 🤖 This project was developed with the help of a LLM/AI such as Cursor, Gemini, etc.

Added to documentation?

  • 📜 README.md
  • 📓 ClickUp
  • 🙅 No documentation needed

Added tests?

  • 👍 Yes
  • 🙅 No, because they aren't needed
  • 🙋 No, because I need help

Testing Instructions

  • Run npm run font:generate
  • Confirm Inter still retains "fontWeight": "100 900"
  • Confirm src paths update correctly

Reviewer's Testing Checklist

As a reviewer, please verify that the relevant testing criteria are fulfilled and confirmed before approving this Pull Request.

  • Visual Regression Testing: Ensure that existing functionality is not negatively impacted by the changes.
  • Cross-Browser Compatibility: Test on major browsers (Chrome, Firefox, Safari) to ensure compatibility.
  • Mobile Responsiveness: Confirm that the changes are responsive and functional on various mobile devices.
  • Theme Compatibility: Ensure that the changes do not adversely affect the site's theme and styling.
  • Linting: Check that the code passes all linting checks (PHPCS, ESLint, SassLint). Check if PR passes code quality check.
  • Accessibility Testing: Validate that the changes comply with accessibility standards. Run npm run a11y.
  • Security Best Practices: Ensure that the code follows WordPress security best practices. Check if PR passes security check.
  • Documentation: Ensure that any new features or changes are appropriately documented in the README.md or Confluence.
  • Post-Deployment Tasks: Check if there are any tasks that need to be performed after deployment.

[optional] Additional Reviewer Notes or Considerations?

khleomix added 10 commits April 2, 2026 03:53
Use __dirname for CopyPlugin contexts so assets copy correctly when the
build runs outside the theme directory. Normalize font output to
fonts/[path][name][ext] to avoid double slashes in emitted paths.

Made-with: Cursor
Webpack already copies assets/fonts into build/fonts; dev servers no
longer require PHP on every start.

Made-with: Cursor
Clarify that build/start copy fonts from assets, and when to run
npm run fonts or fonts:generate.

Made-with: Cursor
@khleomix khleomix self-assigned this Apr 1, 2026
@khleomix khleomix requested a review from thatmitchcanter April 1, 2026 21:14
@khleomix khleomix marked this pull request as ready for review April 20, 2026 21:15
Copy link
Copy Markdown
Member

@thatmitchcanter thatmitchcanter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @khleomix - thanks!

@thatmitchcanter thatmitchcanter merged commit 1207ed9 into main Apr 21, 2026
6 checks passed
@thatmitchcanter thatmitchcanter deleted the hotfix/WDSEN-56-Font-Build-Process branch April 21, 2026 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants