feat(Match): Filter out detected ideas from pre-authored choices #2184#2185
Merged
Conversation
hirokiterashima
added
the
enhancement
breity
requested changes
May 21, 2025
breity
left a comment
breity
left a comment
Member
There was a problem hiding this comment.
Looks good, but I needed to make a couple changes to get it to work properly. See code suggestions and explanations.
breity
approved these changes
May 21, 2025
Member
Author
|
🎉 This PR is included in version 5.184.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
If the student has an idea that is authored as one of the choices, remove it from the choices to avoid duplication. We consider it a duplication if choice.id (authored choice) and idea.name (detected student idea) are the same.
Test Prep
For a unit with DG connected to a Match component, author choices in the match component. Using the advanced JSON editing, give the choices the same ids as the choice names in the CRaterRubric.ideas.name.
Test
Ensure that choices with the same id do not appear more than once in the choices array.
Closes #2184