Several Post-Launch Requests#1184
Open
brianravi wants to merge 25 commits into
Open
Conversation
This was
linked to
issues
Oct 27, 2023
Collaborator
|
Alright I'll review it this weekend and let you know if we need to meet Monday. Thank you! |
Contributor
Author
|
Sounds good, thanks!
The only action I know that will be required on your part is a result of issue #1171
#1171
You will need to update the JSON files to place the keys into the project JSON files so that they pull in the shared questions where you want them.
…________________________________
From: Andy Meneely ***@***.***>
Sent: Friday, October 27, 2023 3:35 PM
To: VulnerabilityHistoryProject/vulnerability-history ***@***.***>
Cc: Brian Robbins ***@***.***>; Author ***@***.***>
Subject: Re: [VulnerabilityHistoryProject/vulnerability-history] Several Post-Launch Requests (PR #1184)
Alright I'll review it this weekend and let you know if we need to meet Monday. Thank you!
—
Reply to this email directly, view it on GitHub<#1184 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/A4BVYS566X6N5XHBKCB2KJ3YBQEHTAVCNFSM6AAAAAA6TE7JNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBTGQYTCNZWGM>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addressed several post-launch requests
Have you...
Gemfile.lockandyarn.lockare't getting modified unintentionally?The above things are not required, but appreciated.