Fix/pr 5202 gantt zoomscale review#5220
Merged
Merged
Conversation
_sortScales accessed timelineHeader.scales.length without checking that scales was defined. When only zoomScale is configured (and the zoom scale manager has not populated scales yet), timelineHeader.scales is undefined, so opening the Gantt threw. Guard the access with timelineHeader?.scales. Closes #5159
…antt-zoomscale-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
fix #5159
💡 Background and solution
When Gantt is configured with timelineHeader.zoomScale but without timelineHeader.scales, _sortScales could access missing scales and crash during initialization. The fix now initializes timeline scales from the configured scales, the active zoomScale level, or a safe default day scale.
This PR also avoids sharing the mutable default scale object across calls, preventing generated timelineDates from leaking between Gantt instances.
📝 Changelog
☑️ Self-Check before Merge
🚀 Summary
copilot:summary
🔍 Walkthrough
copilot:walkthrough