feat: support theming conversion funnel arrow via series.funnel.conve…#4623
Merged
skie1997 merged 1 commit intoJul 15, 2026
Merged
Conversation
…rsionArrow Expose the conversion funnel arrow (line / symbol / text) styles through the series.funnel.conversionArrow theme token, so they can be styled at the theme level in addition to the spec. Defaults mirror the previous hardcoded values, so existing charts render unchanged.
skie1997
approved these changes
Jul 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 This is a ...
🔗 Related issue link
N/A
🔗 Related PR link
N/A
💡 Background and solution
The conversion funnel (
conversionFunnel,@visactor/vchart-extension) draws each conversion-rate connector as three marks — leader line (polygon), arrow head (symbol), label (text). Their styles were hardcoded and only overridable viaspec.conversionArrow.*; there was no theme-level entry point.series.funnel.conversionArrow(line/symbol/text) toIFunnelSeriesTheme, with built-in defaults in the common funnel theme.line.stroke: black,symbol.fill: black,text: #606773 / 12) → non-breaking; existing charts render unchanged.getTheme('series','funnel').conversionArrowand injects it between defaults and spec. Merge order: default → theme → spec (spec wins).points, symbolx/y/angle, text auto-position).📝 Changelog
conversionArrow(line / symbol / text) via theseries.funnel.conversionArrowtheme token (defaults unchanged, non-breaking)series.funnel.conversionArrow主题 token 配置转化漏斗转化率箭头(引导线 / 箭头 / 文字)样式(默认值不变,向后兼容)☑️ Self-Check before Merge