Exposing IMAGE_RESOURCE_DIRECTORY fields and removing Characteristics…#390
Open
gljiva wants to merge 1 commit into
Open
Exposing IMAGE_RESOURCE_DIRECTORY fields and removing Characteristics…#390gljiva wants to merge 1 commit into
gljiva wants to merge 1 commit into
Conversation
… from sanity check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IMAGE_RESOURCE_DIRECTORY fields are currently treated as variables which doesn't account for multiple directories having different field values. Creating struct array for resources_dir to reflect this which enables for the following signatures:
for any i in (0 .. pe.number_of_resources_dir - 1) : ( pe.resources_dir[i].characteristics == 0xbadc00de )Also removing
resource_dir->Characteristicssanity check as the Characteristics field can have arbitrary value.Fixes #295.