Skip to content

feat: add print completion-script command - #128

Open
unicoderbot[bot] wants to merge 4 commits into
mainfrom
vgv-ai-bot/issue-58
Open

feat: add print completion-script command#128
unicoderbot[bot] wants to merge 4 commits into
mainfrom
vgv-ai-bot/issue-58

Conversation

@unicoderbot

@unicoderbot unicoderbot Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Closes #58

This PR was generated by vgv-ai-bot.

@unicoderbot @marcossevilla
fix: address issue #58
0468366 
Closes #58

Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
@unicoderbot
unicoderbot Bot requested a review from a team as a code owner August 10, 2026 12:58
@unicoderbot unicoderbot Bot mentioned this pull request Aug 10, 2026
Open
1 task
@marcossevilla marcossevilla changed the title fix: address issue #58 feat: add print completion-script command Aug 10, 2026
@marcossevilla marcossevilla moved this from Needs Triage to Backlog in VGV Open Source 🦄 🧙🌟 Aug 12, 2026
@marcossevilla marcossevilla moved this from Backlog to In Progress in VGV Open Source 🦄 🧙🌟 Aug 12, 2026
marcossevilla
marcossevilla reviewed Aug 18, 2026
View reviewed changes

@marcossevilla marcossevilla left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the new completion-script command. Ran dart analyze, dart format --set-exit-if-changed, and the full test suite against this branch: all clean, 186 tests passing with 100% coverage. Also verified the error-routing behavior explicitly since it's the crux of this feature: printCompletionScript() sends the script itself through completionLogger.info (stdout), while both CompletionInstallationException and generic exceptions go through completionInstallationLogger.warn/.err (stderr via mason_logger) — so a failure won't corrupt a user's ~/.zshrc when piping with >>. No correctness bugs found, just two minor notes below.

Comment thread lib/src/installer/completion_installation.dart
Comment thread lib/src/command_runner/commands/print_completion_script_command.dart
@marcossevilla

marcossevilla commented Aug 18, 2026

Copy link
Copy Markdown
Member

@vgvbot /address-review

@unicoderbot

unicoderbot Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

On it, I'll address the review comments and push the changes.

  • Preparing environment
    • Cloning repository
    • Setting up dev environment
  • Reviewing feedback
  • Working on changes
  • Pushing updates

I've pushed changes to address the feedback.

@unicoderbot @marcossevilla
fix: address review feedback on PR #128
246c11e 
Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
marcossevilla
marcossevilla reviewed Aug 18, 2026
View reviewed changes
Comment thread test/src/command_runner/commands/handle_completion_command_test.dart.vm.json Outdated
@marcossevilla

marcossevilla commented Aug 18, 2026

Copy link
Copy Markdown
Member

@vgvbot /address-review

@unicoderbot

unicoderbot Bot commented Aug 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

On it, I'll address the review comments and push the changes.

  • Preparing environment
    • Cloning repository
    • Setting up dev environment
  • Reviewing feedback
  • Working on changes
  • Pushing updates

I've pushed changes to address the feedback.

@unicoderbot @marcossevilla
fix: address review feedback on PR #128
3b13c57 
Co-authored-by: marcossevilla <marcossevilla@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marcossevilla marcossevilla marcossevilla approved these changes

Assignees

No one assigned

Labels

None yet

Projects

VGV Open Source 🦄 🧙🌟
Status: In Progress

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: Add "print completion" command.

1 participant

@marcossevilla