Skip to content

Open desktop external web links in the default browser - #29

Merged
VdustR merged 1 commit into
mainfrom
codex/fix-external-browser-links
Nov 1, 2026
Merged

VdustR merged 1 commit into
mainfrom
codex/fix-external-browser-links

Conversation

@VdustR

@VdustR VdustR commented Nov 1, 2026

Copy link
Copy Markdown
Owner

Desktop web links currently do nothing because the shell denies every popup and external navigation. Forward HTTP/HTTPS links without embedded credentials to the system default browser while retaining app popup denial, offline request blocking and the existing homepage Leave behavior.

Add the focused Electron regression to CI and record the reproduction, native Mac acceptance and low-risk assessment in desktop integration notes. Bump Offline to 0.0.18 for the normal all-platform release.

Validation: original/fixed/original shell probe exits 1/0/1; actual Chrome tab launch observed on macOS 26.6.2 arm64 / Electron 45; browser-launch error reporting, protocol denial and offline fetch checked; 79 tests, typecheck, 60 compiler probes and 3,059 payload hashes passed. Native browser launch on other operating systems remains unverified.

@changeset-bot

changeset-bot Bot commented Nov 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 0d3e6ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

VdustR commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

The Changesets warning is informational for this repository's manual versioning workflow: the patch Changeset was already applied with pnpm version:release. This head includes the resulting 0.0.17 → 0.0.18 package version and generated changelog entry. Retaining another pending Changeset would make the release planner reject the build.

@VdustR
VdustR marked this pull request as ready for review November 1, 2026 09:26
@VdustR
VdustR merged commit 13dfa82 into main Nov 1, 2026
8 checks passed
@VdustR
VdustR deleted the codex/fix-external-browser-links branch November 1, 2026 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant