Skip to content

Fix offline Friends and live checkpoint handling - #26

Merged
VdustR merged 4 commits into
mainfrom
codex/finish-recorded-followups
Nov 1, 2026
Merged

VdustR merged 4 commits into
mainfrom
codex/finish-recorded-followups

Conversation

@VdustR

@VdustR VdustR commented Nov 1, 2026 •

Copy link
Copy Markdown
Owner

The offline Friends page displays 0/undefined and controls that need the online service. Replace them with a localized explanation using the existing layout and Back/Escape navigation. Keep the online route intact and reject unsupported upstream shapes during preparation.

Extended native acceptance also exposed a renamed live checkpoint method falling through to the unsupported-online proxy. Resolve that exact account/ticket/report call to local keepLive persistence; unrelated unsupported operations still reject. Acceptance invokes the actual gameplay checkpoint and checks its persisted report. A separate macOS input probe reproduced native focus loss after reload despite document.hasFocus() returning true; test input preparation awaits native focus events and verifies both BrowserWindow and webContents before gameplay keys. Production input and permission policies are unchanged. Menu-only tests now use the actual Back button; a held preview-mesh reference must detach after launch, preventing the Mewtwo overlay caused by the old test shortcut.

Validation: 66 tests, strict checking of 82 maintained TypeScript inputs, 60 compiler probes, 3,059 payload hashes, and focused native Friends/storage and reload-focus controls pass. Full macOS native acceptance passes, including five maps, real pointer capture/camera/Escape/resume/map controls, the actual gameplay checkpoint, Friends, appearance images, unlocks, persistence, and network isolation. Current-head CI passes all six validation jobs. Offline 0.0.16 is versioned with Changesets. A fresh audit of 119 dependencies reports zero known vulnerabilities.

Passive review observation: no automated reviewer has started; complete pagination found no submitted reviews or review threads.

Upstream 0.8.86 remains held: a private compatibility probe reproduced an unsupported autoWaiting call during boot. It is not accepted by this PR; the new recovery contract is tracked in upstream compatibility issue. The separate Dependabot alert still displays its old minimatch 10.2.6 record after a successful supported retry, although the committed graph and GitHub SBOM resolve 11.0.3; no alert was dismissed.

Before: undefined friend limit and unusable online controls

After: localized offline explanation and existing Back navigation

@changeset-bot

changeset-bot Bot commented Nov 1, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: ff1bd8e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@VdustR

VdustR commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

The Changeset was already applied using this repository's manual versioning workflow. This PR includes the resulting package version and CHANGELOG entry; pending Changeset files must be consumed before delivery because the release planner rejects them. See release versioning. The release-planning checks passed for the current head, so no additional Changeset is needed.

@VdustR VdustR changed the title Explain Friends availability in the offline edition Fix offline Friends and live checkpoint handling Nov 1, 2026
@VdustR

VdustR commented Nov 1, 2026

Copy link
Copy Markdown
Owner Author

Native reproduction of the center-screen Mewtwo reported during testing: the direct menu-only toMenu() test call left the selected preview in the renderer. Returning through the actual Back button removes the preview when gameplay launches. The test now uses Back on menu screens and retains the visible preview mesh reference to assert that its parent becomes null after launch. The run settlement flow is unchanged.

The corrected full macOS native run passes five maps, real pointer/camera/Escape/resume/map controls, local gameplay checkpoints, appearance/Friends, persistence and network isolation. These images use disposable profiles.

Before: the test shortcut leaves Mewtwo over the active character

After: normal Back navigation removes the character preview

@VdustR
VdustR marked this pull request as ready for review November 1, 2026 03:27
@VdustR
VdustR merged commit 4f2b1bf into main Nov 1, 2026
8 checks passed
@VdustR
VdustR deleted the codex/finish-recorded-followups branch November 1, 2026 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant