Skip to content

Fix notification navigator not recognizing ChannelActivity notifications #1667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
LuisMend12 wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Fix notification navigator not recognizing ChannelActivity notifications #1667

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7cb3fb1
Fix: notification navigator doesn't recognize ChannelActivity notific…
LuisMend12 Aug 22, 2026
fdd659f
Update Valour/Client/Utility/NotificationNavigator.cs
LuisMend12 Aug 22, 2026
d3cd836
Update Valour/Tests/Client/NotificationNavigatorTests.cs
LuisMend12 Aug 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions Valour/Client/Utility/NotificationNavigator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,19 @@ private static (long PlanetId, long ThreadId)? TryParseThreadRoute(string clickU
return null;
}

private static readonly HashSet<NotificationSource> PlanetChannelRouteSources = new()
{
NotificationSource.PlanetMemberMention,
NotificationSource.PlanetRoleMention,
NotificationSource.PlanetMemberReply,
NotificationSource.PlanetHereMention,
NotificationSource.PlanetEveryoneMention,
NotificationSource.ChannelActivity,
};

internal static bool IsPlanetChannelRouteSource(NotificationSource source) =>
PlanetChannelRouteSources.Contains(source);

public static async Task NavigateTo(Notification notification)
{
if (notification?.Client is null)
Expand All @@ -71,11 +84,7 @@ public static async Task NavigateTo(Notification notification)
{
switch (notification.Source)
{
case NotificationSource.PlanetMemberMention:
case NotificationSource.PlanetRoleMention:
case NotificationSource.PlanetMemberReply:
case NotificationSource.PlanetHereMention:
case NotificationSource.PlanetEveryoneMention:
case var source when IsPlanetChannelRouteSource(source):
{
var planetId = notification.PlanetId;
var channelId = notification.ChannelId;
Expand Down
34 changes: 34 additions & 0 deletions Valour/Tests/Client/NotificationNavigatorTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
using Valour.Client.Utility;
using Valour.Shared.Models;

namespace Valour.Tests.Client;

public class NotificationNavigatorTests
{
[Theory]
[InlineData(NotificationSource.ChannelActivity)]
[InlineData(NotificationSource.PlanetMemberMention)]
[InlineData(NotificationSource.PlanetRoleMention)]
[InlineData(NotificationSource.PlanetMemberReply)]
[InlineData(NotificationSource.PlanetHereMention)]
[InlineData(NotificationSource.PlanetEveryoneMention)]
public void IsPlanetChannelRouteSource_ForPlanetChannelSources_ReturnsTrue(NotificationSource source)
{
Assert.True(NotificationNavigator.IsPlanetChannelRouteSource(source));
}

[Theory]
[InlineData(NotificationSource.DirectMention)]
[InlineData(NotificationSource.DirectReply)]
[InlineData(NotificationSource.DirectMessage)]
[InlineData(NotificationSource.ThreadComment)]
[InlineData(NotificationSource.ThreadReply)]
[InlineData(NotificationSource.FriendRequest)]
[InlineData(NotificationSource.FriendRequestAccepted)]
[InlineData(NotificationSource.EventReminder)]
[InlineData(NotificationSource.Platform)]
public void IsPlanetChannelRouteSource_ForNonPlanetChannelSources_ReturnsFalse(NotificationSource source)
{
Assert.False(NotificationNavigator.IsPlanetChannelRouteSource(source));
}
}