Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: add client side tools to mapper and runtime #819
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uh oh!
There was an error while loading. Please reload this page.
feat: add client side tools to mapper and runtime #819
Changes from 1 commit
6cbcef28913bd6File filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm a bit confused what this is for
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe a more consistent name compared to the other markers, which include
CONVERSATIONAL? I'm thinkingIS_CONVERSATIONAL_CLIENT_SIDE_TOOL?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, I guess related to my comment here. Personally would prefer if a single place creates/outputs the executingToolCall event, especially since right now it seems to be split across two repos and could add some confusion. Is there a code-place where any path (including tools with interrupts) eventually converge to once they are ready to run the tool?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasnt able to get them to fire in a single place, because the MessageMapper processes the AIMessage before the tool node runs (MessageMapper sees tool calls at stream time), but the graph isn't ready to receive responses until interrupt time. For tools that don't need a response from the user, this doesn't matter. For tools that pause and wait, the emission must happen after the pause (tool confirmation and client side tools).
I added it in both places to keep the events consistent for tool calls, but it's a no-op for non interrupt tools anyways. I think if it's causing issues, removing it from non interrupt tools might be the better case so that users wont get confused and try to handle that event.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use
CLIENT_SIDE_TOOL_MARKERCheck failure on line 527 in src/uipath_langchain/runtime/runtime.py
Refactor this function to reduce its Cognitive Complexity from 19 to the 15 allowed.
Uh oh!
There was an error while loading. Please reload this page.