fix(tests): make maestro-stuck-rpa-job manifest CLI-version-agnostic#813
Conversation
|
Claude finished @MarinRzv's task in 1m 26s —— View job Reviewing PR #813
SummaryDrops the Change-by-Change Review1.
|
| Area | Status | Notes |
|---|---|---|
| Frontmatter | N/A | No skill files changed |
| E2E Tests | OK | Fixture fix for existing test — no new coverage needed |
| Skill Body | N/A | No skill files changed |
| References & Assets | OK | All referenced response files exist |
| Repo Hygiene | OK | No secrets, no cross-skill refs, scoped change |
Issues for Manual Review
None found.
Conclusion
Clean, well-scoped fix. The PR description clearly explains the root cause (match string missed the bpmn segment, causing fallthrough to unmocked_default), and the substring approach is validated by the dispatcher's matching logic. Approve.
Drop the leading `maestro` prefix from the manifest match strings for the maestro-namespaced rules so they substring-match both the legacy (`maestro instance ...`) and the current (`maestro bpmn instance ...`) CLI forms. Recorded responses and success criteria are unchanged. The triage agent follows the playbook which uses the current `maestro bpmn instance incidents ...` form. The recorded match string was `maestro instance incidents ...` (no `bpmn`), so the call fell through to `unmocked_default` and returned `[]`, hiding the inner `NodeNotFoundException` evidence that the LLM judge requires. With the prefix-agnostic match string, the fixture is reachable through the current CLI form and the test passes on the original (unmodified) skill files. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
f08eacd to
097f0f1
Compare
…813) Drop the leading `maestro` prefix from the manifest match strings for the maestro-namespaced rules so they substring-match both the legacy (`maestro instance ...`) and the current (`maestro bpmn instance ...`) CLI forms. Recorded responses and success criteria are unchanged. The triage agent follows the playbook which uses the current `maestro bpmn instance incidents ...` form. The recorded match string was `maestro instance incidents ...` (no `bpmn`), so the call fell through to `unmocked_default` and returned `[]`, hiding the inner `NodeNotFoundException` evidence that the LLM judge requires. With the prefix-agnostic match string, the fixture is reachable through the current CLI form and the test passes on the original (unmodified) skill files. Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Drop the leading
maestroprefix from the manifest match strings for the maestro-namespaced rules so they substring-match both the legacy (maestro instance ...) and the current (maestro bpmn instance ...) CLI forms. Recorded responses and success criteria are unchanged.The triage agent follows the playbook which uses the current
maestro bpmn instance incidents ...form. The recorded match string wasmaestro instance incidents ...(nobpmn), so the call fell through tounmocked_defaultand returned[], hiding the innerNodeNotFoundExceptionevidence that the LLM judge requires. With the prefix-agnostic match string, the fixture is reachable through the current CLI form and the test passes on the original (unmodified) skill files.