Skip to content

fix(tests): make maestro-stuck-rpa-job manifest CLI-version-agnostic#813

Merged
MarinRzv merged 1 commit into
mainfrom
fix/maestro-stuck-rpa-job-manifest-cli-prefix
May 18, 2026
Merged

fix(tests): make maestro-stuck-rpa-job manifest CLI-version-agnostic#813
MarinRzv merged 1 commit into
mainfrom
fix/maestro-stuck-rpa-job-manifest-cli-prefix

Conversation

@MarinRzv
Copy link
Copy Markdown
Collaborator

Drop the leading maestro prefix from the manifest match strings for the maestro-namespaced rules so they substring-match both the legacy (maestro instance ...) and the current (maestro bpmn instance ...) CLI forms. Recorded responses and success criteria are unchanged.

The triage agent follows the playbook which uses the current maestro bpmn instance incidents ... form. The recorded match string was maestro instance incidents ... (no bpmn), so the call fell through to unmocked_default and returned [], hiding the inner NodeNotFoundException evidence that the LLM judge requires. With the prefix-agnostic match string, the fixture is reachable through the current CLI form and the test passes on the original (unmodified) skill files.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 17, 2026

Claude finished @MarinRzv's task in 1m 26s —— View job


Reviewing PR #813

  • Read review criteria and project conventions
  • Read PR diff and full changed file
  • Check for cross-skill references, secrets, and link integrity
  • Post review

Summary

Drops the maestro prefix from five manifest match strings in the maestro-stuck-rpa-job test fixture so the substring matcher works with both the legacy CLI form (maestro instance …) and the current form (maestro bpmn instance …). Adds a _doc field to each modified rule explaining the rationale. No skill files or success criteria changed.

Change-by-Change Review

1. tests/tasks/uipath-diagnostics/maestro-stuck-rpa-job/fixtures/mocks/responses/manifest.json

Severity: OK

The change is correct and well-motivated. The mock dispatcher (_shared/mock_template/mocks/uip, line 180) uses plain substring matching (match not in args), so stripping the maestro prefix from match strings like:

  • maestro instance asset …instance asset …
  • maestro instance get …instance get …
  • maestro instance incidents …instance incidents …
  • maestro instance element-executions …instance element-executions …
  • maestro instance cursors …instance cursors …

…means these rules now match both maestro instance … (legacy) and maestro bpmn instance … (current). The GUIDs in each match string are specific enough that false-positive substring collisions are not a concern.

The non-maestro rules (or jobs …, or folders …, traces spans …, docsai ask) are correctly left unchanged — those namespaces are stable and don't have the same version ambiguity.

The _doc annotations on each modified rule are helpful for future maintainers and don't add token noise since fixture JSON is not loaded into agent context.

What's Missing

Nothing identified.

Area Ratings

Area Status Notes
Frontmatter N/A No skill files changed
E2E Tests OK Fixture fix for existing test — no new coverage needed
Skill Body N/A No skill files changed
References & Assets OK All referenced response files exist
Repo Hygiene OK No secrets, no cross-skill refs, scoped change

Issues for Manual Review

None found.

Conclusion

Clean, well-scoped fix. The PR description clearly explains the root cause (match string missed the bpmn segment, causing fallthrough to unmocked_default), and the substring approach is validated by the dispatcher's matching logic. Approve.


Drop the leading `maestro` prefix from the manifest match strings for the
maestro-namespaced rules so they substring-match both the legacy
(`maestro instance ...`) and the current (`maestro bpmn instance ...`) CLI
forms. Recorded responses and success criteria are unchanged.

The triage agent follows the playbook which uses the current `maestro bpmn
instance incidents ...` form. The recorded match string was `maestro
instance incidents ...` (no `bpmn`), so the call fell through to
`unmocked_default` and returned `[]`, hiding the inner `NodeNotFoundException`
evidence that the LLM judge requires. With the prefix-agnostic match string,
the fixture is reachable through the current CLI form and the test passes
on the original (unmodified) skill files.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@MarinRzv MarinRzv force-pushed the fix/maestro-stuck-rpa-job-manifest-cli-prefix branch from f08eacd to 097f0f1 Compare May 18, 2026 07:21
@MarinRzv MarinRzv merged commit 0c7814a into main May 18, 2026
10 checks passed
@MarinRzv MarinRzv deleted the fix/maestro-stuck-rpa-job-manifest-cli-prefix branch May 18, 2026 07:28
charlesliu9 pushed a commit that referenced this pull request May 19, 2026
…813)

Drop the leading `maestro` prefix from the manifest match strings for the
maestro-namespaced rules so they substring-match both the legacy
(`maestro instance ...`) and the current (`maestro bpmn instance ...`) CLI
forms. Recorded responses and success criteria are unchanged.

The triage agent follows the playbook which uses the current `maestro bpmn
instance incidents ...` form. The recorded match string was `maestro
instance incidents ...` (no `bpmn`), so the call fell through to
`unmocked_default` and returned `[]`, hiding the inner `NodeNotFoundException`
evidence that the LLM judge requires. With the prefix-agnostic match string,
the fixture is reachable through the current CLI form and the test passes
on the original (unmodified) skill files.

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants