Conversation
… logic in PublishAssessmentModal
…sment score extraction and update related components
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Publish Assessment and project grade export were reading only
assessment_resultand flattening scores as{ Criterion: { currentScore } }. Hook studies storeaiHook_{id}(or{name}_{skill}_assessment) in other shapes, so CSV, Moodle grades, and the grades ZIP came out as zeros. This PR looks up those keys, flattens the stored value throughscoresFromStoredValueinassessment-score, and prefills Moodle connection fields from settings.Improvements
rpc.moodleAPI.*when a parent form starts with{}(MoodleOptions.vue). Assignment ID is still picked per publish.assessment-scoreexportsscoresFromStoredValuefor NLP lists, numeric maps, and saved criterion state. Publish Assessment andexport.jsboth import it. Tests cover the list and map cases.Bug Fixes
assessment_result, including trigger rows with a null session (PublishAssessmentModal.vue).moodleOptions: {}so the form actually renders.aiHook_%and*_assessmentas well asassessment_result, groups duplicate keys, and prefers a non-zero saved result over the hook row (export.js).Known Limitations
Future Steps