Skip to content

refactor(ui5-table): warn at runtime for non-interactive navigation#13543

Merged
aborjinik merged 1 commit into
mainfrom
table-row-action-navigation-button
May 22, 2026
Merged

refactor(ui5-table): warn at runtime for non-interactive navigation#13543
aborjinik merged 1 commit into
mainfrom
table-row-action-navigation-button

Conversation

@aborjinik
Copy link
Copy Markdown
Contributor

  • Adds a runtime console.warn when <ui5-table-row-action-navigation> is connected without the (deprecated) interactive property and nudges consumers toward the accessible button rendering before V3 removal.
  • No behavior change. Samples and tests already set interactive={true} and are unaffected.
  • Test pages now uses Text component in the ui5-table-cell instead of Label component.
  • Stacking context is set on the table for the sticky elements. Fixes: [Table]: The message strip cuts off the table #13483

@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 18, 2026

Sample sync reminder

HTML sample changed but React sample (sample.tsx) not updated:

  • main/Table/MergedCells

Please keep both samples in sync, or ignore if the change does not apply to both.

@ui5-webcomponents-bot
Copy link
Copy Markdown
Collaborator

ui5-webcomponents-bot commented May 18, 2026

🧹 Preview deployment cleaned up: https://pr-13543--ui5-webcomponents.netlify.app

@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 18, 2026 14:28 Inactive
@aborjinik aborjinik force-pushed the table-row-action-navigation-button branch from 9d8a4e0 to 199df6e Compare May 18, 2026 15:15
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 18, 2026 15:22 Inactive
@aborjinik aborjinik requested review from KvM2 and simlin May 20, 2026 13:46
@aborjinik
Copy link
Copy Markdown
Contributor Author

@aborjinik aborjinik force-pushed the table-row-action-navigation-button branch from 199df6e to e11a3b9 Compare May 20, 2026 17:58
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 20, 2026 18:05 Inactive
@aborjinik aborjinik requested a review from ilhan007 May 21, 2026 05:40
Comment thread packages/main/src/TableRowActionNavigation.ts Outdated
Comment thread packages/main/src/TableRowActionNavigation.ts Outdated
Copy link
Copy Markdown
Contributor

@KvM2 KvM2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few suggestions

Comment thread packages/website/docs/_samples/main/Table/Basic/sample.html
Copy link
Copy Markdown

@simlin simlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@aborjinik aborjinik force-pushed the table-row-action-navigation-button branch from e11a3b9 to e6736bd Compare May 22, 2026 10:19
@ui5-webcomponents-bot ui5-webcomponents-bot temporarily deployed to preview May 22, 2026 10:26 Inactive
@aborjinik aborjinik requested review from KvM2 and simlin May 22, 2026 13:47
@aborjinik aborjinik merged commit 9d4737f into main May 22, 2026
21 of 22 checks passed
@aborjinik aborjinik deleted the table-row-action-navigation-button branch May 22, 2026 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Table]: The message strip cuts off the table

4 participants