Skip to content

Establish approval-rule readiness and defer unproven providers - #163

Merged
BunsDev merged 9 commits into
mainfrom
approval-provider-gates
Oct 11, 2026
Merged

BunsDev merged 9 commits into
mainfrom
approval-provider-gates

Conversation

@BunsDev

@BunsDev BunsDev commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

Approval rules remain disabled after broader live Jev evaluation found six false allows in 62 checks: quoted test-command mentions and destructive suffixes hidden by truncation. This change records the fixed evaluation corpus, reproducible judge/ACP probes, spec reconciliation, and a prepared human acceptance checklist. Readiness is a documented no-go.

Gemini 0.63.0 and Grok 1.0.46 remain deferred. Gemini completed a live text turn, resume, and cancellation, but its permission probe timed out during initialization. Grok accepted cached authentication and session RPCs, then its text turn timed out. The feasibility documents distinguish observed failures from unverified capabilities. Production gates, the backend registry, and CLI-only coding execution are unchanged.

Reconciles published follow-up history and the original readiness work with main after #166. Retains the exact-identifier native input helper and the Streamer detached-range regression while preserving current main's attachment readiness and native recovery coverage. The seven typed input queries avoid the earlier XCTest keyboard-placeholder crash; they do not claim to repair the separately observed workspace-menu opening failure.

Validation of source tree cdfb4027 on Node 24.18.1 / npm 11.16.0:

  • Build and all typechecks passed; 834 unit tests passed, with 12 Windows-only skips.
  • Full desktop E2E: 241 passed, including real OpenKnowledge; site E2E: seven passed.
  • Offline approval evaluation: 11/11, settings unchanged, gate off. These results do not override the six historical live false allows.
  • Xcode 26.6 / iOS 26.5: 41 native unit and all 28 UI tests passed, with zero failures or skips, on an isolated iPhone 16 Pro simulator. Fixture and process cleanup passed; only the owned simulator was shut down, and global settings were unchanged.
  • All 536 tracked files stayed unchanged through the gates and actual-main parent replay. The final three-file documentation update changes no executable source. Hosted checks passed on 8b89a2b: both push and PR macOS jobs passed 833 unit tests (13 skips), 241 desktop E2E and seven site E2E tests; both push and PR iPhone jobs passed all 28 UI tests. Windows and Linux jobs also passed.

The earlier Node 26 full gate stopped on three private-LAN HTTPS timeouts. With unchanged compiled source, the focused network suite reproduced all three failures on Node 26 and passed all eight cases on CI-supported Node 24. The precise OS/runtime cause remains unproven; no privacy/network settings, test assertions, or timeouts changed. Earlier local and hosted failures remain in the linked evidence.

Readiness and human acceptance, CI failure analysis, Gemini deferral, Grok deferral.

Human real-CLI approval acceptance is prepared, not performed. Neither provider is enabled.

@vercel

vercel Bot commented Oct 11, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
modex Ready Ready Preview Oct 11, 2026 10:59pm UTC

Request Review

@BunsDev BunsDev self-assigned this Oct 11, 2026
Wait for the composer drop handler before synthetic file delivery. Restrict native input queries to exact text-field identifiers to avoid XCTest keyboard placeholder faults.

Coven-Harness: Codex / gpt-6
Reproduce detached highlight ranges and skip them before comparing quote endpoints. Preserve full-mask, clipboard, storage, and public-text assertions.

Coven-Harness: Codex / gpt-6
Preserve the original readiness evidence and published CI follow-ups while
integrating main after the Companion delivery. Keep the six live judge false
allows, approval gate off, and Gemini/Grok deferrals explicit. Retain exact
native input queries and the detached highlight regression.

Verified build/typecheck, 834 unit passes with 12 Windows-only skips, 241
desktop and seven site E2E passes, 11 offline approval checks, and 41 native
unit plus 28 UI passes. Preserve the earlier Node 26 LAN failures; the final
three-file documentation update changes no executable source.

Coven-Harness: Codex CLI / gpt-6-astra
@BunsDev
BunsDev merged commit 8e13d4a into main Oct 11, 2026
7 checks passed
@BunsDev
BunsDev deleted the approval-provider-gates branch October 13, 2026 12:48

This branch was successfully deployed

1 active deployment
Preview — 8b89a2b6 Deployed Oct 11, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant