Repository navigation
test: restore out-of-range answer coverage for all four questions - #61
Merged
Merged
Conversation
The phase 1 extraction did not carry over the playground test "decision
table: out-of-range probabilities and confidence never permit"
(typesafe-playground tests/proposal-review.test.ts at 408ebb5). The
existing invariant test covered addresses_task only and asserted the
verdict, not the named miss. This restores the full 4 ids x {probability,
confidence} x {-0.01, 1.01, -2, 2} grid and asserts each reason names
"<id>: no usable answer", plus permit at p = 1/0.
Test-only. No verdict, decision-table row, threshold, or fixture changes.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Restores a playground test that the phase 1 extraction (#32) did not carry over:
decision table: out-of-range probabilities and confidence never permitfromtypesafe-playgroundtests/proposal-review.test.tsat408ebb55086fb9b6d517dc5a11aa1c404117f699(#41 head; tree-identical to merge6fe5967).The existing
tests/answer-invariants.test.tscase coveredaddresses_taskonly and asserted the verdict, not the named miss. The restored test runs all 4 question ids × {probability,confidence} × {−0.01, 1.01, −2, 2} (32 cases). For each case it assertsproposal_onlyand checks that the reason contains<id>: no usable answer. It also assertspermitat p = 1/0. The only adaptation is the harness's review-envelope helper.Mutation check: if
decide()'sconfidence > 1bound is removed, the existing invariant test still passes, because the contradiction check catches the case with a different reason. The restored test fails. So this closes a real gap in the regression net.Verdict impact
None. This PR changes tests only. No decision-table row, threshold, question wording or version, fixture, or mock verdict changes.
Verification
pnpm typecheckpnpm test: 346 pass, 0 fail (pnpm verify: boundaries, typecheck, tests, build, secrets, all passing)🤖 Generated with Claude Code