Repository navigation
feat: expose manual Jev API key override in Settings - #26
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The settings verifier is not included in the documented browser-verification entry points.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Adds a Settings-based manual Jev API key override with masked save/replace/remove, persistence, cross-tab synchronization, and updated documentation.
Changes:
- Replaces the API-key dialog with a Settings drawer.
- Adds key precedence and browser lifecycle verification.
- Updates responsive styling and user guidance.
| File | Summary |
|---|---|
tests/live-host.test.ts |
Tests server/manual key precedence. |
scripts/verify-arena-settings-browser.mjs |
Adds browser verification for the settings lifecycle. |
scripts/verify-arena-controls-browser.mjs |
Updates control verification. |
README.md |
Updates key-management guidance. |
docs/verification/arena-key-settings-2026-09-22.json |
Records browser verification results. |
docs/routing-demo.md |
Documents override behavior and storage. |
components/header.tsx |
Implements Settings UI and key lifecycle handling. |
app/globals.css |
Styles the responsive Settings drawer. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The manual Jev API-key override is now explicit under Settings → Jev API key. The overlay shows the active key source, supports save/replace/remove, confirms successful changes, and returns to the server default when the override is removed. The header indicates when a manual override is active.
Saved values remain masked and are never redisplayed. Cross-tab key changes clear stale drafts/confirmations and invalidate current arena results. The existing origin-local storage and request-header precedence remain unchanged; no provider request is made by saving a key.
Verdict impact
None. No fixture verdicts, routing decisions, question wording, model pin or execution authority change.
Verification
pnpm typecheckpnpm test— 84 offline testspnpm buildpnpm check:secretsandgit diff --checkThe verification record covers 51 browser assertions for key activation, replacement, removal, persistence, header precedence, storage failures, cross-tab changes, overlay focus and responsive layout. An injected-provider test verifies server-default → manual → replacement → server-default precedence without live calls. Human VoiceOver and real-device acceptance were not performed.