Repository navigation
chore: ignore the default routing-run.json bench artifact - #23
Merged
Merged
Conversation
README.md and docs/routing.md tell readers to produce routing-run.json at the repository root with `pnpm --silent bench:routing > routing-run.json`. The file was neither tracked nor ignored, so following the docs left a permanent untracked entry in `git status`. Ignore the root-anchored default path only; a run artifact that is meant to be linked can still be committed deliberately under another name or directory. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
5 tasks done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
One rule appended to
.gitignore:/routing-run.json(root-anchored), with a comment pointing at the docs that produce it.README.md(line 210) anddocs/routing.md(line 54) tell readers to runpnpm --silent bench:routing > routing-run.jsonat the repository root. That file was neither tracked nor ignored, so following the docs leaves a permanent untracked entry ingit status. Only the default root path is ignored: a run artifact that is meant to be linked from a measured claim can still be committed deliberately under another name or directory.No source, test, doc, fixture, CI, or dependency change.
Verdict impact
None. No fixture, verdict, decision-table row, question wording, or routing outcome changes.
Verification
git check-ignore -v routing-run.json→.gitignore:25:/routing-run.jsonpnpm typecheck/pnpm testunaffected (no code change; last run onmainat29e3834: clean, 63/63)b5b5412, SSH ED25519,%G?= G)🤖 Generated with Claude Code