Skip to content

Missed locale usage#29

Open
Typositoire wants to merge 3 commits intoTryGhost:mainfrom
Typositoire:fix/missing_locale_featured
Open

Missed locale usage#29
Typositoire wants to merge 3 commits intoTryGhost:mainfrom
Typositoire:fix/missing_locale_featured

Conversation

@Typositoire
Copy link
Copy Markdown

@Typositoire Typositoire commented Mar 10, 2026

This seems to have been an oversight! The locale exists, but is never used!


Note

Low Risk
Small translation/context and version bump changes limited to a single template string; minimal functional impact.

Overview
Fixes an i18n oversight by switching the Featured section heading in partials/featured-posts.hbs to use {{t "Featured"}} instead of a hardcoded string.

Updates locales/context.json to register source/partials/featured-posts.hbs as a usage site for the Featured locale key, and bumps the theme version to 1.0.1.

Written by Cursor Bugbot for commit 94a7b35. This will update automatically on new commits. Configure here.

@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Mar 10, 2026

Warning

Rate limit exceeded

@Typositoire has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 19 minutes and 54 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5499089c-19ab-47a7-b08d-fd025d5fcc02

📥 Commits

Reviewing files that changed from the base of the PR and between 47c73c5 and 94a7b35.

📒 Files selected for processing (1)
  • locales/context.json

Walkthrough

The pull request contains two changes: the package version is updated from "1.0.0" to "1.0.1" in package.json, and in the featured-posts partial template, the static text "Featured" is replaced with an internationalization call using {{t "Featured"}} to enable locale-aware rendering.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately describes the main change: adding missing locale usage to the featured posts header.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The description clearly explains the i18n oversight being fixed: switching the 'Featured' heading to use the translation function and updating the version.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@partials/featured-posts.hbs`:
- Line 6: The translation key usage for "{{t "Featured"}}" was added in
partials/featured-posts.hbs but locales/context.json wasn’t updated; open
locales/context.json, find the translation entry that lists usage sites for the
"Featured" key (the existing usage array near the current "Featured" entry) and
add an entry referencing partials/featured-posts.hbs (or the appropriate partial
identifier) so the registry includes this new usage and stays in sync with the
template.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1483fedc-459d-48ed-ab4b-61ef08eb4bbf

📥 Commits

Reviewing files that changed from the base of the PR and between 9195dd6 and 47c73c5.

📒 Files selected for processing (2)
  • package.json
  • partials/featured-posts.hbs

Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Free Tier Details

Your team is on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle for each member of your team.

To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

@Typositoire
Copy link
Copy Markdown
Author

I found another one (Show More) but this one is missing all the languages, I can push it with French and AI the rest if that's okay with you. Otherwise I'll leave my PR at this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant