This repository was archived by the owner on Aug 18, 2020. It is now read-only.
Feat/modal component#358
Closed
GirishSarbhukan wants to merge 9 commits intoTripwire:masterfrom
Closed
Conversation
Contributor
|
This looks like it contains the Button changes from #357 - was that intentional? The description of this PR implies that it should just be for the Modal. |
Contributor
Author
|
Deleting this branch due to having Button related irrelevant changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented Modal dialog as per UX screen.
This includes:
- Default modal dialog with close button
- Default Line modal dialog with close button
- Modal with Info, success,warning and error dialog
- Modal with Confirmation dialog
Note: By mistake there is small typo in .md file "modal with Info success warning Errom dialog" , we will correct the same.
Pending : Adding 2 modal dialog form as an example given in Octagon Design System. Do we really need to create those?
@andrewleyva : Request you to please review the code changes and share the feedback.